Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect handling of protocol relative URLs #241

Open
johndaniels opened this issue Dec 19, 2012 · 1 comment · May be fixed by #351
Open

Incorrect handling of protocol relative URLs #241

johndaniels opened this issue Dec 19, 2012 · 1 comment · May be fixed by #351

Comments

@johndaniels
Copy link

in Firefox and Chrome, history.pushState('//example.com/foo') will be equivalent to history.pushSate('/foo') bringing you to 'http://example.com/foo'.

In history.js, history.pushState('//example.com/foo') brings you to 'http://example.com/example.com/foo'. History.js should recognize that as a protocol relative URL and treat it accordingly.
@jacobsvante
Copy link

I've noticed this as well. Protocol-less URLs are an awesome feat to have if making your page available both with http and https. I'll submit a pull request in a few minutes.

@jacobsvante jacobsvante linked a pull request Oct 21, 2013 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support protocol-relative URL:s jacobsvante/history.js
2 participants
@jacobsvante @johndaniels