Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support protocol-relative URL:s #351

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jacobsvante
Copy link

I.e. without URL:s without http/https in front of them. Fixes #241.

@hirasso
Copy link

hirasso commented Jun 11, 2015

@jmagnusson, thanks for this fix! Can you tell me how to compile this into the full history.min.js file, so that I can use it?

@jacobsvante
Copy link
Author

I've never tried buildr that they seem to use, but my guess is (from the command prompt):

  1. Install Node.js
  2. git clone https://github.com/browserstate/history.js.git
  3. cd history.js
  4. npm install
  5. ./node_modules/buildr/bin/buildr

@hirasso
Copy link

hirasso commented Jun 11, 2015

Thanks! I ended up just editing the uncompressed bundled script: https://github.com/browserstate/history.js/blob/master/scripts/bundled-uncompressed/html4%2Bhtml5/jquery.history.js

I'm uglifiying it with gulp anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect handling of protocol relative URLs
2 participants