Modify history.js to match current W3C popState event semantics (uncompresses only) #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 7, 2011 19:09
" 4. If the third argument is present, set the document's current address to the absolute URL that was found earlier in this algorithm. Since this is neither a navigation of the browsing context nor a history traversal, it does not cause a hashchange event to be fired. " I believe that " this is not a navigation" also applies to popState (as this this cause applies to push push and replace state) The changes to history.js bring statechange (event) in line with the spec.
|
does this change make history a true polyfill ? I.e. you can drop it in and it just 'works' (apart from the # in the url) |
|
+1 The way history.js diverts from the spec makes it completely unusable as a drop-in replacement to overcome one or two minor browser quirks. |
|
This appears to fix issue 47. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"
4. If the third argument is present, set the document's current address to the absolute URL that was found earlier in this algorithm.
Since this is neither a navigation of the browsing context nor a history traversal, it does not cause a hashchange event to be fired.
"
I believe that " this is not a navigation" also applies to popState (as this this cause applies to push push and replace state)
The changes to history.js bring statechange (event) in line with the spec.