Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempted fix for issue #339 - no more including host in hash on IE 8 and 9 #366

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kontur
Copy link

@kontur kontur commented Nov 29, 2013

In Internet Explorer IE8 and IE9 there seems to be a problem that includes the host in the hash.

http://www.example.com/?page=foobar -> http://www.example.com/#http://www.exmaple.com?page=foobar&_suid=123456789
but    
http://www.example.com/directory/?page=foobar -> http://www.example.com/directory/#?page=foobar&_suid=123456789

I noticed that in History.getShortUrl the baseUrl reports "http://www.example.com/" with a trailing slash. Consequently, shortUrl.replace, does not match anything because of the superfluous "/" at the end of baseUrl. Removing the trailing slash fixes the problem, as shortUrl gets returned correctly.

I only applied this to the uncompressed html4+html5 bundle for jquery as I have not used the other library integrations.

@LiamKarlMitchell
Copy link

Merge please.

@ryanmcnz
Copy link

ryanmcnz commented Jun 5, 2015

Can confirm that this fixes the issue, just experienced this exact URL problem with the host duplicating into the hash.

Fix also works with the uncompressed bundle for native as well.

@kontur
Copy link
Author

kontur commented Jun 5, 2015

Thanks for confirming 👍

@adlq
Copy link

adlq commented Sep 11, 2015

I also can confirm this issue, please merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants