Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the code for new state empty title issue in History.setTitle method. #476

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rajkumar-duvva
Copy link

Issue : In History.setTitle method, if new state title is empty, document title getting updated with empty value and title is showing the URL.

Fix : To fix this, document title is updated when new state title is not empty in History.setTitle method.

Copy link
Author

@rajkumar-duvva rajkumar-duvva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated title check condition with null and undefined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant