This repository has been archived by the owner on Dec 8, 2019. It is now read-only.
PIR Enhancements #42
Open
PIR Enhancements #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HASS supports a binary sensor for motion, so this commit leverages that.
Whoops, added a space that I didn't mean to add...
I've been fighting with line endings and must have missed this in the chaos.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some basic changes to PIR functionality - most importantly, changed the PIR from a "sensor" to a "binary sensor," which should be a better platform to base that kind of sensor on - we even get a fancy icon that changes color for motion! This also means that it should act similarly to other properly configured motion sensors in our environments.
I also broke out the spot where the PIR string is defined in case people want to simplify it down to "on/off" etc, but left the defaults for compatibility with old HASS configurations.