feat: update cli interface to be more elixir based #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| {:ok, %{rows: _rows}} -> | ||
| true | ||
|
|
||
| # We return true on failure to ensure we don't accidently delete |
There was a problem hiding this comment.
[misspell] reported by reviewdog 🐶
"accidently" is a misspelling of "accidentally"
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| seeds_file = Path.join([priv_dir, repo_underscore, "seeds.exs"]) | ||
|
|
||
| if File.regular?(seeds_file) do | ||
| Code.eval_file(seeds_file) |
Check warning
Code scanning / Sobelow
Code execution in eval function Warning
|
|
||
| @spec has_data?(module(), String.t(), String.t()) :: boolean() | ||
| defp has_data?(repo, schema, table) do | ||
| case Ecto.Adapters.SQL.query(repo, "SELECT * FROM #{schema}.#{table} LIMIT 1") do |
Check warning
Code scanning / Sobelow
SQL injection Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to dig into the Elixir cli a bit more and see if it's possible to pass in remote commands so I can make a cli that has commands like
remote iexandremote migrate(remote + a cli command = running that command in remote)