Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add legend option #41

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add legend option #41

wants to merge 2 commits into from

Conversation

toben
Copy link

@toben toben commented Apr 1, 2020

I just added an option to enable or disable legends for datamaps. I hope this is good for you.

btmills
btmills requested changes Apr 1, 2020
View reviewed changes
Copy link
Owner

@btmills btmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for enabling this! Would you mind adding it to examples/ as well?

src/datamap.jsx Outdated Show resolved Hide resolved
@toben @btmills
Update "legends" prop typo
da66507 
Co-Authored-By: Brandon Mills <btmills@users.noreply.github.com>
@toben
Copy link
Author

toben commented Apr 2, 2020

I will add it to examples then and try to respect your typo :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btmills btmills btmills requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@toben @btmills @mberbegal