Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update redisson proxy manager to support redisson 3.21.0 #370

Merged
merged 1 commit into from May 2, 2023

Conversation

koenpunt
Copy link
Contributor

@koenpunt koenpunt commented May 1, 2023

The synchronous command executor has been removed from Redisson in version 3.21.0.

@vladimir-bukhtoyarov
Copy link
Collaborator

Good, I will look tomorrow.

@vladimir-bukhtoyarov vladimir-bukhtoyarov changed the base branch from master to 8.3 May 2, 2023 07:55
@koenpunt
Copy link
Contributor Author

koenpunt commented May 2, 2023

@vladimir-bukhtoyarov cool, I've already rebased the changes on the 8.3 branch

@vladimir-bukhtoyarov vladimir-bukhtoyarov merged commit f109fcc into bucket4j:8.3 May 2, 2023
vladimir-bukhtoyarov pushed a commit that referenced this pull request May 2, 2023
vladimir-bukhtoyarov added a commit that referenced this pull request May 2, 2023
@vladimir-bukhtoyarov
Copy link
Collaborator

Released with version 8.3.0

@koenpunt koenpunt deleted the redisson-3.21.0 branch May 3, 2023 09:06
@koenpunt
Copy link
Contributor Author

koenpunt commented May 3, 2023

Had to find out about the new group id because 8.3.0 isn't available on com.github.vladimir-bukhtoyarov; would it be an idea to release a final version update on the old group id which then deprecates the code and suggests changing the group?
This would really help people using dependabot to keep there dependencies up to date.

@vladimir-bukhtoyarov
Copy link
Collaborator

vladimir-bukhtoyarov commented May 3, 2023

GroupId is "com.bucket4j". It was changed about 1 year ago. New groupId is mentioned on github project page.

would it be an idea to release a final version update on the old group id which then deprecates the code and suggests changing the group?

I am limited in time that I can afford to spend for this library, so I prefer to spend it carefully, mostly to new features and enhancements.

@koenpunt
Copy link
Contributor Author

koenpunt commented May 3, 2023

I understand.

But if someone doesn't visit the GitHub page they won't know. And gradle or maven doesn't know about this name change either, so it was just something to consider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants