Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement UnifiedJedis builder for JedisBasedProxyManager #420

Conversation

tgregory-block
Copy link
Contributor

This implements support for Jedis's UnifiedJedis interface in JedisBasedProxyManager. Makes it simpler to work with various Redis setups.

I didn't bother including another test for clustered mode as the underlying class, JedisCluster is the same. Let me know if it'd be preferred to add a separate test where we wrap it in UnifiedJedis before running the test

@vladimir-bukhtoyarov vladimir-bukhtoyarov changed the base branch from master to 8.7 November 4, 2023 13:10
@vladimir-bukhtoyarov vladimir-bukhtoyarov merged commit 5dd727c into bucket4j:8.7 Nov 4, 2023
@vladimir-bukhtoyarov
Copy link
Collaborator

will be released next weekend

@vladimir-bukhtoyarov
Copy link
Collaborator

@tgregory-block

JedisCluster is the same. Let me know if it'd be preferred to add a separate test where we wrap it in UnifiedJedis before running the test

Yes, it would be nice to have a case for RedisCluster. please add new item there https://github.com/bucket4j/bucket4j/blob/8.7/bucket4j-redis/src/test/java/io/github/bucket4j/redis/RedisClusterTest.java#L67

I have already merged current request, so it need to open new, use 8.7 branch as source and target for new PR.

@tgregory-block tgregory-block deleted the tgregory/unified-jedis-support branch November 6, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants