Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs update: pagination slot #3868

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

OlegKlochkov
Copy link
Contributor

Proposed Changes

  • Add b-table's pagination slot to docs

@@ -509,6 +509,11 @@ export default [
description: 'Custom top-left (opposite side of top pagination)',
props: '—'
},
{
name: '<code>pagination</code>',
Copy link
Member

@wesdevpro wesdevpro Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OlegKlochkov I thought this was already in the docs. And I don't believe there is a prop called pagination for the table component

Copy link
Collaborator

@kikuomax kikuomax Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wesdevpro I think this PR is relevant, because pagination is not a prop but a named slot that BTable actually has:

<slot name="pagination">
<b-table-pagination
v-bind="$attrs"
:per-page="perPage"
:paginated="paginated"
:rounded="paginationRounded"
:icon-pack="iconPack"
:total="newDataTotal"
:current-page.sync="newCurrentPage"
:aria-next-label="ariaNextLabel"
:aria-previous-label="ariaPreviousLabel"
:aria-page-label="ariaPageLabel"
:aria-current-label="ariaCurrentLabel"
@page-change="(event) => $emit('page-change', event)"
:page-input="pageInput"
:pagination-order="paginationOrder"
:page-input-position="pageInputPosition"
:debounce-page-input="debouncePageInput"
>
<slot name="top-left"/>
</b-table-pagination>
</slot>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do see that now on line 23.

@wesdevpro
Copy link
Member

Closing this PR because it has been stale for a while. Feel free to open a PR and communicate. Thanks

@wesdevpro wesdevpro closed this Aug 30, 2023
@kikuomax kikuomax reopened this Aug 31, 2023
@wesdevpro wesdevpro merged commit f60370c into buefy:dev Sep 22, 2023
1 check passed
kikuomax pushed a commit to kikuomax/buefy that referenced this pull request Jan 10, 2024
kikuomax pushed a commit to kikuomax/buefy that referenced this pull request Feb 11, 2024
kikuomax pushed a commit to ntohq/buefy-next that referenced this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants