Apply CDN Fixes to Buefy v0.9.25 #3894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added mobileModal to Clockpicker Component * Added mobileModal to Timepicker Component
* feat: 🎸 Adding a new prop to set the id for inner input Adding a new prop to set the id for inner input for checkbox component * docs: ✏️ Adding helping data on checkbox api file * refactor: 💡 Changing prop name
* Numberinput: fix long-press breaking when disabled * Numberinput: fix long-press unit test
Updated documentation for attribute `auto-close` from #3855
- Fixes the bug that `Datepicker` ended up with an infinite loop when a user tried to move focus onto an unselectable cell.
…ng the value (#3884) (#3886) * fix(lib): Input not validate on value prop change - Fixes the bug that `Input` did not validate an updated value if `value` prop was updated from outside; i.e., without user interaction. Runs validation whenever `value` is changed from outside. It determines the update is from outside if `computedValue` and the new value are different. Intentionally uses `!=` instead of `!==`, because `computedValue` and `value` may be either string or number. * test(lib): test validation on Input - Introduces new test cases for `Input` that test validation runs on relevant events: - "input" event - "change" event - `value` prop is programmatically changed Also tests cases where the `Input` value has v-model binding. These tests make sure that the chain of events won't run validation twice on the same value.
…) persists after value is corrected (#3883) (#3885) * fix(lib): validation error on addons persisted - Fixes the bug that a validation error on a `Field` that wraps multile child components (has addons) persisted. `Field` wraps its slot in another `Field` (wrapper) if the slot is consisting of multiple components. It used to propagate `newType` to the wrapper, but this prevented the type of the wrapper updated once `newType` was set due to the line: https://github.com/buefy/buefy/blob/6f41e91bd24dfef8f680f27313e07b488ddcfc1d/src/utils/FormElementMixin.js#L137 Propagates `type` instead of `newType` to the wrapper. * test(lib): add test for Field's type - Adds a new test case for `Field` that tests if `Field` containing multiple components (addons) reflects the validation status of a wrapped input. This verifies the fix of the bug that `Field` with addons did not update its validation status (`newType`) once it was set.
* Add nearbyMonthDays prop support to Datetimepicker Add Datepicker component prop `nearby-month-days` to Datetimepicker component * FIX lint Datetimepicker.vue * Use Datepicker default behavior for nearbyMonthDays prop * Update datetimepicker api doc with nearbyMonthDays prop
* Updated The Documentation's Twitter Link * Updated Sponsor Links * Update FUNDING.yml
* fix: dist not included in published package - Fixes the bug that no `dist` folder was included in the published package: #3890 (comment) Adds `prepare` script to `package.json` to make sure `build:lib` is run before publishing. One could insert `npm run build:lib` before `npm publish` in `npm_deploy.yml` file, but `prepare` script has a few more benefits that other publishing methods, e.g., npm install via GitHub, yalc, become available. * fix: bump CircleCI Node to v18.18 - Due to new `prepare` script, CircleCI now runs the `vetur` script that is incompatible with Node v8.x during `npm install`: #3891 (comment) Node v18.x should work. * fix: Date/time pickers' locale-dependent results - Fixes the issue that specs of date/time pickers failed depending on the locale of the machine running the tests. - `Datepicker.spec.js` fixes the locale to "en-US" - `Datetimepicker.spec.js` fixes the locale to "en-US" - `Timepicker.spec.js` fixes the locale, and hour format to "en-US", and "24" respectively - `DatepickerMonth` uses the local timezone to create date fixtures. It used to use UTC but should be the local timezone because `DatepickerMonth` deals with the local timezone. * fix: flaky test case of Numberinput - Fixes the issue that the test case "increments/decrements on long pressing exponentially" of `Numberinput` randomly failed. Uses Jest's fake timer instead of the real timer to make the behavior predictable. * fix: Numberinput checkHtml5Validity errors in tests - Fixes the issue that the spec of `Numberinput` printed error messages when it tried to call `checkHtml5Validity` of a default mock `Input`. Supplies a special mock `Input` that implements a fake `checkHtml5Validity` method. * chore: update spec snapshots - Updates outdated spec snapshots. The following changes were made since the last snapshots had been taken: - `Checkbox.spec.js.snap`: `id` was added - `Clockpicker.spec.js.snap`: `trigger-tab-index` was added to `Dropdown` - `Colorpicker.spec.js.snap`: - `trigger-tab-index` was added to `Dropdown` - `aria-modal` was removed - `Datepicker.spec.js.snap`: - `trigger-tab-index` was added to `Dropdown` - `aria-modal` was removed - `Dropdown.spec.js.snap`: - `role` was removed - `aria-modal` was moved to the inside `div` - `NavbarDropdown.spec.js.snap`: `navbar-dropdown` was split into `is-hidden-touch` and `is-hidden-desktop` - `Pagination.spec.js.snap`: `pagination-inpu` was introduced - `Sidebar.spec.js.snap`: hidden `button` was introduced - `StepItem.spec.js.snap`: attribute order was changed, maybe because `elementClass` was moved to `staticClass` in `TabbedChildMixin` - `Steps.spec.js.snap`: attribute order of `StepItem` was changed - `TabItem.spec.js.snap`: attribute order was changed, maybe because `elementClass` was moved to `staticClass` in `TabbedChildMixin` - `Tabs.spec.js.snap`: - `role` and `aria-orientation` were moved to the inside `ul` - `role`, `aria-controls`, and `aria-selected` of `a` were moved to surrounding `li` - attribute order of `TabItem` was changed - `Taginput.spec.js.snap`: `keep-open` became `true` by default - `Timepicker.spec.js.snap`: - `trigger-tab-index` was added to `Dropdown` - spec specified the locale to make outputs predictable - `Tooltip.spec.js.snap`: `span` became `div` - The following snapshots change but are not included: - `CarouselList.spec.js.snap`: I am sceptic about reproducibility, because it includes some information for coverage calculation - `Collapse.spec.js.snap`: I was not able to explain how the old snapshot was taken
* Fix: Expired and broken websites in expo page (#3780) * Fix: Full width sidebar doesn't have a close button (#3802) * Fix: Full width sidebar doesn't have a close button (#3802) - format code * Fix: Full width sidebar doesn't have a close button (#3802) - Add documentation * Fix eslint errors in pagination examples
✅ Deploy Preview for buefy-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@kikuomax the goal of this PR is to apply the fixes to v0.9.24 in |
kikuomax
reviewed
Sep 26, 2023
|
@wesdevpro To make the commit history between |
wesdevpro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.