Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GeneratedFile.jsDoc() and other features to @bufbuild/protoplugin #649

Merged
merged 10 commits into from Dec 8, 2023
Merged

Add GeneratedFile.jsDoc() and other features to @bufbuild/protoplugin #649

merged 10 commits into from Dec 8, 2023

Commits on Dec 7, 2023

  1. Deprecate Schema from @bufbuild/protoplugin over Schema from @bufbuil… 

    …d/protoplugin/ecmascript
    @timostamm
    timostamm committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    bb981dc View commit details
    Browse the repository at this point in the history

  2. Add GeneratedFile.string and deprecate stringLiteral()

    @timostamm
    timostamm committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    105770b View commit details
    Browse the repository at this point in the history

  3. Use GeneratedFile.string in protoc-gen-es

    @timostamm
    timostamm committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    77103f0 View commit details
    Browse the repository at this point in the history

  4. Prepare to deprecate createJsDocBlock() and makeJsDoc()

    @timostamm
    timostamm committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    0c93926 View commit details
    Browse the repository at this point in the history

  5. Add GeneratedFile.jsDoc() and deprecate createJsDocBlock() and makeJs… 

    …Doc()
    @timostamm
    timostamm committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    a1e18d4 View commit details
    Browse the repository at this point in the history

  6. Use GeneratedFile.jsDoc() in protoc-gen-es

    @timostamm
    timostamm committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    e5b509f View commit details
    Browse the repository at this point in the history

  7. Deprecate GeneratedFile.export and export createImportSymbol() from @… 

    …bufbuild/protoplugin/ecmascript as a more flexible replacement
    @timostamm
    timostamm committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    69d2e6e View commit details
    Browse the repository at this point in the history

  8. Do not trim file contents in tests 

    We can't test for leading or trailing whitespace otherwise. Instead, just remove a final newline at the end before we split, so we don't have an extra line.
    @timostamm
    timostamm committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    08fb556 View commit details
    Browse the repository at this point in the history

  9. Move toResponse() to create-es-plugin.ts 

    So we can add more control over supported features for editions
    @timostamm
    timostamm committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    baede97 View commit details
    Browse the repository at this point in the history

  10. Simplify the internal SchemaController.prepareGenerate

    @timostamm
    timostamm committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    740e0e1 View commit details
    Browse the repository at this point in the history