Validator bug fix, previously results in error: '[Validator] unknown … #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lang parameter'. Condition correction. Bug fixed. It works now.
|
|
|
This behavior is by design - see the discussion here: #717 (comment) The validate-{cpp,go,java} binaries are meant to be used without specifying a language option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running proto buf compiler with --validate_out="lang=go:./proto" was always giving error: '[Validator] unknown lang parameter'. Upon code analysis I found that this condition checks if the langParamValue is not empty and fails with the error message above.
The problem is that it fails even when it should not. Fixed issue, modified this condition to check if the lang parameter value is not equal to the expected language.
Hope this is fine.
Thanks!