Merge pull request #197 from kcasctiv/fix-get-infinite-loop

Fix infinite loop in Get
buger · May 10, 2020 · 5754b3e · 5754b3e
2 parents 57853d8 + b10e032
commit 5754b3e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/parser.go b/parser.go
@@ -294,6 +294,9 @@ func searchKeys(data []byte, keys ...string) int {
 			// can move to the end of this block
 			if !lastMatched {
 				end := blockEnd(data[i:], '{', '}')
+				if end == -1 {
+					return -1
+				}
 				i += end - 1
 			} else {
 				level++

diff --git a/parser_test.go b/parser_test.go
@@ -861,9 +861,15 @@ var getTests = []GetTest{
 	},
 	{
 		// Issue #178: Crash in searchKeys
-		desc: `invalid json`,
-		json: `{{{"":`,
-		path: []string{"a", "b"},
+		desc:    `invalid json`,
+		json:    `{{{"":`,
+		path:    []string{"a", "b"},
+		isFound: false,
+	},
+	{
+		desc:    `opening brace instead of closing and without key`,
+		json:    `{"a":1{`,
+		path:    []string{"b"},
 		isFound: false,
 	},
 }