Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix electron v8 #2141

Draft
wants to merge 7 commits into
base: integration/v8
Choose a base branch
from
Draft

Fix electron v8 #2141

wants to merge 7 commits into from

Conversation

djskinner
Copy link
Contributor

@djskinner djskinner commented May 16, 2024

Goal

Fix the electron tests on v8 branch

Design

Set max_body_size: 25mb on the verdaccio config (local npm where packages are published for the electron tests) to allow for the increased size of @bugsnag/react-nativein v8.

Note the increase in size is expected and is because it contains both prefabs (which are unstripped and have a ton of extra debug info), and the classic JNI .so files. Depending on peoples builds only one gets used, and prefabs are processed before being included in the app. The size of .apk files doesn't get affected, just the .aar files.

@djskinner djskinner changed the base branch from next to integration/v8 May 16, 2024 15:23
@djskinner djskinner force-pushed the fix-electron-v8 branch 7 times, most recently from 9510cc2 to 23c3ac6 Compare May 17, 2024 09:05
Copy link

github-actions bot commented May 20, 2024

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 44.83 kB 13.67 kB
After 44.83 kB 13.67 kB
± No change No change

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against 32df6c2

@gingerbenw
Copy link
Member

@djskinner you can resolve the electron issue by pinning @vercel/webpack-asset-relocator-loader to 1.7.3 - a new version was released last week and seems to have introduced this issue. I also have the fix in #2143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants