Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add php 8.1 to CI + minor CI improvements #629

Merged
merged 3 commits into from Jul 5, 2021
Merged

Add php 8.1 to CI + minor CI improvements #629

merged 3 commits into from Jul 5, 2021

Conversation

imjoehaines
Copy link
Member

@imjoehaines imjoehaines commented Jul 5, 2021 •
edited

Goal

Adds PHP 8.1 to CI with --ignore-platform-req php to allow the latest PHPUnit to install

I've also:

@imjoehaines
Wrap versions in quotes
76fa75d 
This prevents YAML from converting them into floats or integers,
which can lead to unexpected results: 8.0 -> 8 (latest) or
x.10 -> x.1
@imjoehaines
Add PHP 8.1 to test matrix
01e6e1d
@imjoehaines
Force development php.ini values
16d599e
@imjoehaines imjoehaines requested a review from kattrali July 5, 2021 09:15
@imjoehaines imjoehaines merged commit 8899c29 into next Jul 5, 2021
@imjoehaines imjoehaines deleted the test/add-php-8.1 branch July 5, 2021 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kattrali kattrali kattrali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@imjoehaines @kattrali