Use buildbuddy_internal visibility on some enterprise/ packages #3652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9f0a2e5.
sluongng
force-pushed
the
sluongng/gazelle-internal-visible
branch
from
b930ab8
to
b03fa18
Compare
We depend on the open source targets when build from the buildbuddy_internal workspace. Therefore let's allow visibility to all internal subpackages. This is strict enough visibility setting without exposing the structure of our internal repository.
sluongng
force-pushed
the
sluongng/gazelle-internal-visible
branch
from
b03fa18
to
43c4011
Compare
bduffany
approved these changes
Mar 27, 2023
bduffany
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gazelle: allow internal visibility
We depend on the open source targets when build from the
buildbuddy_internal workspace. Therefore let's allow visibility to all
internal subpackages.
This is strict enough visibility setting without exposing the
structure of our internal repository.
Note: The visibility in
enterprise/server/cmd/server/yaml_doc/BUILDwas changedto allow @buildbuddy_internal even though it's not required. This should be fixed
in the next Gazelle release via bazelbuild/bazel-gazelle#1472.
This reverts commit 9f0a2e5.
Closes https://github.com/buildbuddy-io/buildbuddy-internal/issues/2171
Version bump: None