sluongng/upgrade rules go #3699
Conversation
- Upgraded rules_go to v0.39.0 - Upgraded gazelle to v0.30.0 + Patch visibility of @gazelle//internal/module to build `bb` CLI - Upgraded go to 1.20.2 - Upgrade several golang.org/x/... packages This also required us to change how we are registering go_sdk. An issue was reported upstream here bazelbuild/rules_go#3510
sluongng
force-pushed
the
sluongng/upgrade-rules-go
branch
2 times, most recently
from
c28a07f
to
e02ec33
Compare
Fix all the visibility scope issues that was reported in bazelbuild/bazel-gazelle#1467
sluongng
force-pushed
the
sluongng/upgrade-rules-go
branch
from
e02ec33
to
f378b4b
Compare
|
Avoided upgrading go version to 1.20.2. There seem to be several breakages with the new go version. |
|
Not sure how to get past the lint check as we seem to be using an older release of @bduffany do you know if we should build the |
WORKSPACE
Outdated
| @@ -50,36 +50,9 @@ load("@io_bazel_rules_go//go:deps.bzl", "go_download_sdk", "go_register_toolchai | |||
|
|
|||
| go_rules_dependencies() | |||
|
|
|||
There was a problem hiding this comment.
I think there was some reason we wanted to use go_download_sdk instead of go_register_toolchains, maybe related to cross-compilation. Maybe @siggisim remembers?
There was a problem hiding this comment.
Yeah, we want to make sure to be able to download both the linux and mac sdks regardless of host (the default rules only download the SDK from your host machine). This allows you to kick of linux remote execution builds from a mac host, i.e. https://www.buildbuddy.dev/debugging#run-buildbuddy-test-suite-on-linux-remote-ex-from-a-mac
There was a problem hiding this comment.
I pushed a fix in bazelbuild/rules_go#3511 and patched our rules_go with it in the latest version.
Since the rules_go PR is merged, it should be a short-lived patch.
|
@bduffany wdyt about the Check Style failure here? We are using a pinned version of Should the fix be to build or should we upgrade with old style -> release |
this is probably the best option for now. Eventually we want to move checkstyle to bb workflows, and it'll be more feasible to build |
|
close in favor of #3768 |
bbCLIThis also required us to change how we are registering go_sdk. An issue
was reported upstream here bazelbuild/rules_go#3510
Then, run the new gazelle over the repo.
Fix all the visibility scope issues that were reported in
bazelbuild/bazel-gazelle#1467
Please let me know if this PR is too big, I could split it into 2-3 smaller PRs
Version bump: Patch