Remove transaction surrounding createAPIKey call
#6221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 22, 2024
tempoz
force-pushed
the
transaction-not-required-for-fetch-quota-config
branch
from
cff85a9
to
2af560e
Compare
tempoz
force-pushed
the
transaction-unnecessary-for-create-api-key
branch
from
24c2f00
to
42560cc
Compare
tempoz
force-pushed
the
transaction-not-required-for-fetch-quota-config
branch
from
2af560e
to
cc01e1f
Compare
tempoz
force-pushed
the
transaction-unnecessary-for-create-api-key
branch
2 times, most recently
from
56d2730
to
f5cf4a8
Compare
`createAPIKey` makes only one database call at the very end of the transaction, which means the transaction only "rolls back" when that insert fails, anyway, rendering the transaction unnecessary.
tempoz
force-pushed
the
transaction-unnecessary-for-create-api-key
branch
from
dc22e05
to
b4d6a2f
Compare
tempoz
changed the base branch from
transaction-not-required-for-fetch-quota-config
to
master
jdhollen
reviewed
May 29, 2024
jdhollen
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues: N/A