Add plugin for bzr. #143
Add plugin for bzr. #143
Conversation
Supports sync and reup, hopefully as efficiently as is reasonably possible. Requires `bzr` binary in PATH.
|
Sweet! I'll take a look at this later today. |
|
By the way, was the architecture doc helpful at all? As far as I know no one's ever read it. |
|
I did refer to that doc, but mostly copied the hg plugin and then tidied things up a bit. |
|
It looks unrelated to this branch, but is there anything I need to do to fix the AppVeyor build failure? |
|
The AppVeyor failures are totally unrelated, but thanks for checking. You can follow the exciting action at #140. |
|
|
||
| def bzr(path, *args, capture_output=False): | ||
| cwd = os.getcwd() | ||
| os.chdir(path) |
There was a problem hiding this comment.
Can we use Popen's cwd argument instead of calling os.chdir here?
|
Thanks again for the PR, this is great. If you'd prefer that I take it from here that's fine too, though I just installed bzr for the first time :) |
"Every Revision has a Revision ID (also called a revid), which is a long opaque string that serves as a Universally Unique ID; no other Revision anywhere will ever have the same ID, and anywhere this Revision is, it will have that ID." - http://wiki.bazaar.canonical.com/MatthewFuller/SpotDocs/RevNumbering
|
I think I covered all your comments now? Is there anything else I can help with? |
|
I just pushed a branch on top of yours with a few tests: https://github.com/buildinspace/peru/commits/bzr_tests. These are pretty much copies of the hg tests. One of them is failing -- the reason why is that it looks like the bzr plugin never Once that's done, I think we're good to go. Another difference that came up when I was writing the reup test was that I noticed the bzr plugin doesn't support the (somewhat confusingly named) |
|
(Note to self: document the new plugin.) |
|
Hi! I took a xmas break but I'm still interested in landing this. I'll look at the tests and the reup branch name soon ... unless you get there first. |
|
Same here :) All yours. |
|
I still think this is great and plan to get back to it. Looks like we've both been busy with other things. |
|
Yes, it's still on my todo list too. |
Supports sync and reup, hopefully as efficiently as is reasonably
possible.
Requires
bzrbinary in PATH.