docs: Update NGINX proxy example with best practises #2743
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had a customer raise some concerns about our current example so adding extra information for security as the current example shows loose config in terms of not showing usage of the allowing only from the Buildkite IPs and limiting access to specific URLs for the use with Buildkite
By listing the the specific and only URLs/Endpoints required, we can ensure users follow best practices.
Will update PR for review when confirmed all the URLs/Endpoints required for GitHub Enterprise Server.