fix: Registry cache for Azure DevOps #1690
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub <13458283+diznq@users.noreply.github.com>
github-actions
bot
added
the
type/enhancement
jkutner
reviewed
Mar 29, 2023
jkutner
reviewed
Mar 29, 2023
|
I think it's ok to put a dependency on |
cubxxw
approved these changes
Mar 30, 2023
| URL: r.url.String(), | ||
| }) | ||
| if err != nil { | ||
| return errors.Wrap(err, "cloning remote registry") |
There was a problem hiding this comment.
Could such error handling have been more perfect?
Co-authored-by: Joe Kutner <jpkutner@gmail.com> Signed-off-by: Jakub <13458283+diznq@users.noreply.github.com>
Co-authored-by: Joe Kutner <jpkutner@gmail.com> Signed-off-by: Jakub <13458283+diznq@users.noreply.github.com>
|
Strange, did you make mistakes with the rebase, why are there multiple commits? |
Signed-off-by: Jakub <13458283+diznq@users.noreply.github.com>
|
I just signed off the comments raised here but realized strings import wasn't removed and Go is strict about unused stuff |
|
This indicates that recent changes have not achieved the desired coverage, and more work needs to be done to increase coverage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Go Git doesn't work with Azure DevOps due to unsupported protocol: go-git/go-git#64
Output
If
dev.azure.com/URL is used for Git,git cloneis used instead of Go Git library, the downside isgitmust be installed locally