Skip to content

Commit

Permalink
refactor(): encapsulating styles for a few components #1434 (#1445)
Browse files Browse the repository at this point in the history
* fix(Checkbox): updating checkbox, checklist, radio, tiles to have consistent disabled styling

* minor bux fixes plus some more demos

* fix(Checkbox): fixing a display bug introduced with checkboxes and adding demo

* typo

* feat(ng-packagr)!: tree shakable imports (#1413)

* fix(Picker): setting min-width on novo entity picker results (#1406)

* chore(icons): Bump icons version (#1409)

Co-authored-by: Michael Dill <michael.dill@bullhorn.com>

* feat(picker): add maxlength parameter for characters on input (#1411)

* add maxlength parameter

* BH-77751: add default value for maxlength

* Revert "BH-77751: add default value for maxlength"

This reverts commit 3f6b851.

---------

Co-authored-by: russi.sinha <russi.sinha@bullhorn.com>

* feat(ng-packagr): initial rework for tree shakable imports

* missed a tsconfig update

* exporting individual modules for pipes, services, utils

* fixing a test config issue

* fixing some import issues in unit tests

* feat(EntityColor): Add compliance manager entity color (#1415)

* fix(Picker): setting min-width on novo entity picker results (#1406)

* chore(icons): Bump icons version (#1409)

Co-authored-by: Michael Dill <michael.dill@bullhorn.com>

* feat(picker): add maxlength parameter for characters on input (#1411)

* add maxlength parameter

* BH-77751: add default value for maxlength

* Revert "BH-77751: add default value for maxlength"

This reverts commit 3f6b851.

---------

Co-authored-by: russi.sinha <russi.sinha@bullhorn.com>

* add entity color

* update bullhorn-icons

* update bullhorn-icons

* dont update bullhorn-icons

---------

Co-authored-by: Dan Voegelin <dvoegelin@bullhorn.com>
Co-authored-by: Michael Dill <mdill@bullhorn.com>
Co-authored-by: Michael Dill <michael.dill@bullhorn.com>
Co-authored-by: Russi Sinha <87716104+s-russi@users.noreply.github.com>
Co-authored-by: russi.sinha <russi.sinha@bullhorn.com>

* feat(QueryBuilder): new address picker definition for query builder (#1407)

* feat(QueryBuilder): new address picker definition for query builder

* changing placeholder label

* fix(Picker): setting min-width on novo entity picker results (#1406)

* chore(icons): Bump icons version (#1409)

Co-authored-by: Michael Dill <michael.dill@bullhorn.com>

* fixing a few bugs

* feat(picker): add maxlength parameter for characters on input (#1411)

* add maxlength parameter

* BH-77751: add default value for maxlength

* Revert "BH-77751: add default value for maxlength"

This reverts commit 3f6b851.

---------

Co-authored-by: russi.sinha <russi.sinha@bullhorn.com>

* switching parent element ref for overlay to fix width issue

* re-focusing on the address input when selecting an option

* fixing bug with multiple location conditions open at once

---------

Co-authored-by: Michael Dill <mdill@bullhorn.com>
Co-authored-by: Michael Dill <michael.dill@bullhorn.com>
Co-authored-by: Russi Sinha <87716104+s-russi@users.noreply.github.com>
Co-authored-by: russi.sinha <russi.sinha@bullhorn.com>

* fixing import issue from rebase

* fix(Chips): Prevent overwriting value before labels are resolved (#1416)

* fix(Chips): Prevent overwriting value before labels are resolved

When altering the value of a Chips picker, if some values have a label while others do not, the items with no label are no longer removed from the value

* simplify handling

---------

Co-authored-by: Alyssa Bryant <alyssa.bryant@bullhorn.com>

* adding ng-package files to remaining elements

* fixing some build paths

* cleaning up some more imports

---------

Co-authored-by: Michael Dill <mdill@bullhorn.com>
Co-authored-by: Michael Dill <michael.dill@bullhorn.com>
Co-authored-by: Russi Sinha <87716104+s-russi@users.noreply.github.com>
Co-authored-by: russi.sinha <russi.sinha@bullhorn.com>
Co-authored-by: Zachary Jorn <zachary.jorn@bullhorn.com>
Co-authored-by: Trent Hibbard <trent.hibbard@bullhorn.com>
Co-authored-by: Alyssa Bryant <alyssa.bryant@bullhorn.com>

* refactor(dragula): deprecating dragula directive and service (#1420)

* refactor(dragula): deprecating dragula directive and service

* feat()!: breaking change

* Breaking: change

* breaking(): adding breaking change release rule to semantic-release config

* refactor(): moving some extended third party libs out to addons folder

* splitting out form demo page into form and dynamic form

* fixing remote data table demo

* adding new addons package to main novo-elements package

* refactor(date-fns)!: updating date-fns to v2 (#1421)

* fix(Picker): setting min-width on novo entity picker results (#1406)

* chore(icons): Bump icons version (#1409)

Co-authored-by: Michael Dill <michael.dill@bullhorn.com>

* feat(picker): add maxlength parameter for characters on input (#1411)

* add maxlength parameter

* BH-77751: add default value for maxlength

* Revert "BH-77751: add default value for maxlength"

This reverts commit 3f6b851.

---------

Co-authored-by: russi.sinha <russi.sinha@bullhorn.com>

* feat(ng-packagr): initial rework for tree shakable imports

* missed a tsconfig update

* exporting individual modules for pipes, services, utils

* fixing a test config issue

* fixing some import issues in unit tests

* feat(EntityColor): Add compliance manager entity color (#1415)

* fix(Picker): setting min-width on novo entity picker results (#1406)

* chore(icons): Bump icons version (#1409)

Co-authored-by: Michael Dill <michael.dill@bullhorn.com>

* feat(picker): add maxlength parameter for characters on input (#1411)

* add maxlength parameter

* BH-77751: add default value for maxlength

* Revert "BH-77751: add default value for maxlength"

This reverts commit 3f6b851.

---------

Co-authored-by: russi.sinha <russi.sinha@bullhorn.com>

* add entity color

* update bullhorn-icons

* update bullhorn-icons

* dont update bullhorn-icons

---------

Co-authored-by: Dan Voegelin <dvoegelin@bullhorn.com>
Co-authored-by: Michael Dill <mdill@bullhorn.com>
Co-authored-by: Michael Dill <michael.dill@bullhorn.com>
Co-authored-by: Russi Sinha <87716104+s-russi@users.noreply.github.com>
Co-authored-by: russi.sinha <russi.sinha@bullhorn.com>

* feat(QueryBuilder): new address picker definition for query builder (#1407)

* feat(QueryBuilder): new address picker definition for query builder

* changing placeholder label

* fix(Picker): setting min-width on novo entity picker results (#1406)

* chore(icons): Bump icons version (#1409)

Co-authored-by: Michael Dill <michael.dill@bullhorn.com>

* fixing a few bugs

* feat(picker): add maxlength parameter for characters on input (#1411)

* add maxlength parameter

* BH-77751: add default value for maxlength

* Revert "BH-77751: add default value for maxlength"

This reverts commit 3f6b851.

---------

Co-authored-by: russi.sinha <russi.sinha@bullhorn.com>

* switching parent element ref for overlay to fix width issue

* re-focusing on the address input when selecting an option

* fixing bug with multiple location conditions open at once

---------

Co-authored-by: Michael Dill <mdill@bullhorn.com>
Co-authored-by: Michael Dill <michael.dill@bullhorn.com>
Co-authored-by: Russi Sinha <87716104+s-russi@users.noreply.github.com>
Co-authored-by: russi.sinha <russi.sinha@bullhorn.com>

* fixing import issue from rebase

* fix(Chips): Prevent overwriting value before labels are resolved (#1416)

* fix(Chips): Prevent overwriting value before labels are resolved

When altering the value of a Chips picker, if some values have a label while others do not, the items with no label are no longer removed from the value

* simplify handling

---------

Co-authored-by: Alyssa Bryant <alyssa.bryant@bullhorn.com>

* adding ng-package files to remaining elements

* fixing some build paths

* cleaning up some more imports

* refactor(date-fns)!: updating date-fns to v2

* fixing import

* fixing build error

* removing some unused imports

---------

Co-authored-by: Michael Dill <mdill@bullhorn.com>
Co-authored-by: Michael Dill <michael.dill@bullhorn.com>
Co-authored-by: Russi Sinha <87716104+s-russi@users.noreply.github.com>
Co-authored-by: russi.sinha <russi.sinha@bullhorn.com>
Co-authored-by: Zachary Jorn <zachary.jorn@bullhorn.com>
Co-authored-by: Trent Hibbard <trent.hibbard@bullhorn.com>
Co-authored-by: Alyssa Bryant <alyssa.bryant@bullhorn.com>

* refactor(): adding refactor release rule to semantic-release config

* refactor(rxjs): updating rxjs to 7.8.1 (#1419)

* fix(Picker): setting min-width on novo entity picker results (#1406)

* chore(icons): Bump icons version (#1409)

Co-authored-by: Michael Dill <michael.dill@bullhorn.com>

* feat(picker): add maxlength parameter for characters on input (#1411)

* add maxlength parameter

* BH-77751: add default value for maxlength

* Revert "BH-77751: add default value for maxlength"

This reverts commit 3f6b851.

---------

Co-authored-by: russi.sinha <russi.sinha@bullhorn.com>

* feat(ng-packagr): initial rework for tree shakable imports

* missed a tsconfig update

* exporting individual modules for pipes, services, utils

* fixing a test config issue

* fixing some import issues in unit tests

* feat(EntityColor): Add compliance manager entity color (#1415)

* fix(Picker): setting min-width on novo entity picker results (#1406)

* chore(icons): Bump icons version (#1409)

Co-authored-by: Michael Dill <michael.dill@bullhorn.com>

* feat(picker): add maxlength parameter for characters on input (#1411)

* add maxlength parameter

* BH-77751: add default value for maxlength

* Revert "BH-77751: add default value for maxlength"

This reverts commit 3f6b851.

---------

Co-authored-by: russi.sinha <russi.sinha@bullhorn.com>

* add entity color

* update bullhorn-icons

* update bullhorn-icons

* dont update bullhorn-icons

---------

Co-authored-by: Dan Voegelin <dvoegelin@bullhorn.com>
Co-authored-by: Michael Dill <mdill@bullhorn.com>
Co-authored-by: Michael Dill <michael.dill@bullhorn.com>
Co-authored-by: Russi Sinha <87716104+s-russi@users.noreply.github.com>
Co-authored-by: russi.sinha <russi.sinha@bullhorn.com>

* feat(QueryBuilder): new address picker definition for query builder (#1407)

* feat(QueryBuilder): new address picker definition for query builder

* changing placeholder label

* fix(Picker): setting min-width on novo entity picker results (#1406)

* chore(icons): Bump icons version (#1409)

Co-authored-by: Michael Dill <michael.dill@bullhorn.com>

* fixing a few bugs

* feat(picker): add maxlength parameter for characters on input (#1411)

* add maxlength parameter

* BH-77751: add default value for maxlength

* Revert "BH-77751: add default value for maxlength"

This reverts commit 3f6b851.

---------

Co-authored-by: russi.sinha <russi.sinha@bullhorn.com>

* switching parent element ref for overlay to fix width issue

* re-focusing on the address input when selecting an option

* fixing bug with multiple location conditions open at once

---------

Co-authored-by: Michael Dill <mdill@bullhorn.com>
Co-authored-by: Michael Dill <michael.dill@bullhorn.com>
Co-authored-by: Russi Sinha <87716104+s-russi@users.noreply.github.com>
Co-authored-by: russi.sinha <russi.sinha@bullhorn.com>

* fixing import issue from rebase

* fix(Chips): Prevent overwriting value before labels are resolved (#1416)

* fix(Chips): Prevent overwriting value before labels are resolved

When altering the value of a Chips picker, if some values have a label while others do not, the items with no label are no longer removed from the value

* simplify handling

---------

Co-authored-by: Alyssa Bryant <alyssa.bryant@bullhorn.com>

* adding ng-package files to remaining elements

* fixing some build paths

* cleaning up some more imports

* build(rxjs): updating rxjs to 7.8.1

* updated data table refresh subscription to match new typing

* updating project package.json

---------

Co-authored-by: Michael Dill <mdill@bullhorn.com>
Co-authored-by: Michael Dill <michael.dill@bullhorn.com>
Co-authored-by: Russi Sinha <87716104+s-russi@users.noreply.github.com>
Co-authored-by: russi.sinha <russi.sinha@bullhorn.com>
Co-authored-by: Zachary Jorn <zachary.jorn@bullhorn.com>
Co-authored-by: Trent Hibbard <trent.hibbard@bullhorn.com>
Co-authored-by: Alyssa Bryant <alyssa.bryant@bullhorn.com>

* removing unnecessary config property

* removing unnecessary semicolon from scss file

* reorganizing ace-editor and ckeditor examples

* fix(): fixing style encapsulation for a few components

* fixing some scss warnings

* reverting header scss filename

* reverting radio scss filename

* refactor(): moving some extended third party libs out to addons folder (#1430)

* refactor(): moving some extended third party libs out to addons folder

* splitting out form demo page into form and dynamic form

* fixing remote data table demo

* adding new addons package to main novo-elements package

* removing unnecessary semicolon from scss file

* reorganizing ace-editor and ckeditor examples

* adding style encapsulation to a few more components

* adding style encapsulation to a few more components

* feat(DataTable): making data tables emit scroll events through the cdk (#1431)

* adding NovoDragulaService to FormExtras providers for FileInput

* feat(Places): adding keyboard support to places component (#1433)

* feat(Places): adding keyboard support to places component

* giving query builder definition chips a max width and overflow ellipsis

* rebase and fixing merge conflicts

* adding style encapsulation to a few more components

* adding style encapsulation to a few more components

* adding style encapsulation to a few more components

* adding style encapsulation to a few more components

* adding style encapsulation to a few more components

* fixing notinmonth style for date picker

* fix for value icon color

---------

Co-authored-by: Michael Dill <mdill@bullhorn.com>
Co-authored-by: Michael Dill <michael.dill@bullhorn.com>
Co-authored-by: Russi Sinha <87716104+s-russi@users.noreply.github.com>
Co-authored-by: russi.sinha <russi.sinha@bullhorn.com>
Co-authored-by: Zachary Jorn <zachary.jorn@bullhorn.com>
Co-authored-by: Trent Hibbard <trent.hibbard@bullhorn.com>
Co-authored-by: Alyssa Bryant <alyssa.bryant@bullhorn.com>
  • Loading branch information
8 people committed Jul 10, 2023
1 parent 71cd9dc commit 2fbd765
Show file tree
Hide file tree
Showing 100 changed files with 2,077 additions and 2,022 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
novo-agenda-date-change {
@import "../../../styles/variables.scss";

:host {
display: inline-block;

.cal-date-change {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import { DateUtil } from 'novo-elements/utils';
<i class="bhi-arrow-right" (click)="addDate()"></i>
</div>
`,
styleUrls: ['./AgendaDateChange.scss'],
})
export class NovoAgendaDateChangeElement {
/**
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
@import "../../../styles/variables.scss";

:host {
::ng-deep .cal-day-view,
::ng-deep .cal-week-view {
.cal-hour-rows {
width: 100%;
border: solid 1px #e1e1e1;
overflow-x: scroll;
position: relative;
}

.cal-hour:nth-child(even) {
background-color: $off-white;
}
.cal-hour:nth-child(odd) {
background-color: $white;
}

.cal-hour-segment {
height: 30px;
}

.cal-hour-segment::after {
content: "\00a0";
}

.cal-hour:not(:last-child) .cal-hour-segment,
.cal-hour:last-child :not(:last-child) .cal-hour-segment {
border-bottom: thin dashed #e1e1e1;
}

.cal-time {
font-weight: bold;
padding-top: 5px;
width: 70px;
text-align: center;
color: $grey;
}

.cal-hour-segment.cal-after-hour-start {
.cal-time {
display: none;
}
}

.cal-hour-segment:hover,
.cal-drag-over .cal-hour-segment {
background-color: #ededed;
}
}
}
125 changes: 40 additions & 85 deletions projects/novo-elements/src/elements/agenda/day/AgendaDayView.scss
Original file line number Diff line number Diff line change
@@ -1,97 +1,52 @@
.cal-day-view,
.cal-week-view {
.cal-hour-rows {
width: 100%;
border: solid 1px #e1e1e1;
overflow-x: scroll;
position: relative;
}

.cal-hour:nth-child(even) {
background-color: $off-white;
}
.cal-hour:nth-child(odd) {
background-color: $white;
}
@import "../../../styles/variables.scss";

.cal-hour-segment {
height: 30px;
}

.cal-hour-segment::after {
content: "\00a0";
}

.cal-hour:not(:last-child) .cal-hour-segment,
.cal-hour:last-child :not(:last-child) .cal-hour-segment {
border-bottom: thin dashed #e1e1e1;
}

.cal-time {
font-weight: bold;
padding-top: 5px;
width: 70px;
text-align: center;
color: $grey;
}

.cal-hour-segment.cal-after-hour-start {
.cal-time {
display: none;
:host {
::ng-deep .cal-day-view {
.cal-event-container {
position: absolute;
}
}

.cal-hour-segment:hover,
.cal-drag-over .cal-hour-segment {
background-color: #ededed;
}
}

.cal-day-view {
.cal-event-container {
position: absolute;
}

novo-agenda-day-event {
height: inherit;

.cal-event {
novo-agenda-day-event {
height: inherit;
font-size: 12px;
margin-left: 2px;
margin-right: 2px;
min-height: 30px;
display: flex;
flex-flow: row nowrap;
background-color: $off-white;

.cal-event-ribbon {
width: 4px;
min-height: 100%;
}
.cal-event-group {
overflow: hidden;
flex: 1;
padding: 2px 10px;
.cal-event {
height: inherit;
font-size: 12px;
margin-left: 2px;
margin-right: 2px;
min-height: 30px;
display: flex;
flex-flow: column;
}
.cal-event-title {
line-height: 26px;
}
.cal-event-description {
font-size: 10px;
line-height: 13px;
flex-flow: row nowrap;
background-color: $off-white;

.cal-event-ribbon {
width: 4px;
min-height: 100%;
}
.cal-event-group {
overflow: hidden;
flex: 1;
padding: 2px 10px;
display: flex;
flex-flow: column;
}
.cal-event-title {
line-height: 26px;
}
.cal-event-description {
font-size: 10px;
line-height: 13px;
}
}
}
}

.cal-draggable {
cursor: move;
}
.cal-draggable {
cursor: move;
}

.cal-all-day-event {
padding: 8px;
border: solid 1px;
.cal-all-day-event {
padding: 8px;
border: solid 1px;
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ const MINUTES_IN_HOUR: number = 60;
</div>
</div>
`,
styleUrls: ['./AgendaDayView.scss', '../common/AgendaHoursLayout.scss'],
})
export class NovoAgendaDayViewElement implements OnChanges, OnInit, OnDestroy {
/**
Expand Down

0 comments on commit 2fbd765

Please sign in to comment.