refactor(rxjs): updating rxjs to 7.8.1 (#1419)

* fix(Picker): setting min-width on novo entity picker results (#1406) * chore(icons): Bump icons version (#1409) Co-authored-by: Michael Dill <michael.dill@bullhorn.com> * feat(picker): add maxlength parameter for characters on input (#1411) * add maxlength parameter * BH-77751: add default value for maxlength * Revert "BH-77751: add default value for maxlength" This reverts commit 3f6b851. --------- Co-authored-by: russi.sinha <russi.sinha@bullhorn.com> * feat(ng-packagr): initial rework for tree shakable imports * missed a tsconfig update * exporting individual modules for pipes, services, utils * fixing a test config issue * fixing some import issues in unit tests * feat(EntityColor): Add compliance manager entity color (#1415) * fix(Picker): setting min-width on novo entity picker results (#1406) * chore(icons): Bump icons version (#1409) Co-authored-by: Michael Dill <michael.dill@bullhorn.com> * feat(picker): add maxlength parameter for characters on input (#1411) * add maxlength parameter * BH-77751: add default value for maxlength * Revert "BH-77751: add default value for maxlength" This reverts commit 3f6b851. --------- Co-authored-by: russi.sinha <russi.sinha@bullhorn.com> * add entity color * update bullhorn-icons * update bullhorn-icons * dont update bullhorn-icons --------- Co-authored-by: Dan Voegelin <dvoegelin@bullhorn.com> Co-authored-by: Michael Dill <mdill@bullhorn.com> Co-authored-by: Michael Dill <michael.dill@bullhorn.com> Co-authored-by: Russi Sinha <87716104+s-russi@users.noreply.github.com> Co-authored-by: russi.sinha <russi.sinha@bullhorn.com> * feat(QueryBuilder): new address picker definition for query builder (#1407) * feat(QueryBuilder): new address picker definition for query builder * changing placeholder label * fix(Picker): setting min-width on novo entity picker results (#1406) * chore(icons): Bump icons version (#1409) Co-authored-by: Michael Dill <michael.dill@bullhorn.com> * fixing a few bugs * feat(picker): add maxlength parameter for characters on input (#1411) * add maxlength parameter * BH-77751: add default value for maxlength * Revert "BH-77751: add default value for maxlength" This reverts commit 3f6b851. --------- Co-authored-by: russi.sinha <russi.sinha@bullhorn.com> * switching parent element ref for overlay to fix width issue * re-focusing on the address input when selecting an option * fixing bug with multiple location conditions open at once --------- Co-authored-by: Michael Dill <mdill@bullhorn.com> Co-authored-by: Michael Dill <michael.dill@bullhorn.com> Co-authored-by: Russi Sinha <87716104+s-russi@users.noreply.github.com> Co-authored-by: russi.sinha <russi.sinha@bullhorn.com> * fixing import issue from rebase * fix(Chips): Prevent overwriting value before labels are resolved (#1416) * fix(Chips): Prevent overwriting value before labels are resolved When altering the value of a Chips picker, if some values have a label while others do not, the items with no label are no longer removed from the value * simplify handling --------- Co-authored-by: Alyssa Bryant <alyssa.bryant@bullhorn.com> * adding ng-package files to remaining elements * fixing some build paths * cleaning up some more imports * build(rxjs): updating rxjs to 7.8.1 * updated data table refresh subscription to match new typing * updating project package.json --------- Co-authored-by: Michael Dill <mdill@bullhorn.com> Co-authored-by: Michael Dill <michael.dill@bullhorn.com> Co-authored-by: Russi Sinha <87716104+s-russi@users.noreply.github.com> Co-authored-by: russi.sinha <russi.sinha@bullhorn.com> Co-authored-by: Zachary Jorn <zachary.jorn@bullhorn.com> Co-authored-by: Trent Hibbard <trent.hibbard@bullhorn.com> Co-authored-by: Alyssa Bryant <alyssa.bryant@bullhorn.com>
bullhorn · Jun 28, 2023 · c5540e3 · c5540e3
1 parent dc8c603
commit c5540e3
Show file tree

Hide file tree

Showing 11 changed files with 27 additions and 25 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -63,7 +63,7 @@
     "novo-design-tokens": "^0.0.9",
     "post-robot": "9.0.30",
     "resize-observer-polyfill": "^1.5.1",
-    "rxjs": "~6.5.5",
+    "rxjs": "~7.8.1",
     "text-mask-addons": "^3.8.0",
     "timezone-support": "^2.0.2",
     "tslib": "^2.0.0",

diff --git a/projects/novo-elements/src/elements/card/Card.ts b/projects/novo-elements/src/elements/card/Card.ts
@@ -153,9 +153,9 @@ export class CardElement implements OnChanges, OnInit {
   }
 
   @Output()
-  onClose: EventEmitter<any> = new EventEmitter();
+  onClose: EventEmitter<void> = new EventEmitter();
   @Output()
-  onRefresh: EventEmitter<any> = new EventEmitter();
+  onRefresh: EventEmitter<void> = new EventEmitter();
 
   cardAutomationId: string;
   labels: NovoLabelService;

diff --git a/projects/novo-elements/src/elements/data-table/data-table.component.ts b/projects/novo-elements/src/elements/data-table/data-table.component.ts
@@ -369,14 +369,14 @@ export class NovoDataTable<T> implements AfterContentInit, OnDestroy {
   }
 
   @Input()
-  set refreshSubject(refreshSubject: EventEmitter<any>) {
+  set refreshSubject(refreshSubject: EventEmitter<void>) {
     // Unsubscribe
     if (this.refreshSubscription) {
       this.refreshSubscription.unsubscribe();
     }
     if (refreshSubject) {
       // Re-subscribe
-      this.refreshSubscription = refreshSubject.subscribe((filter: any) => {
+      this.refreshSubscription = refreshSubject.subscribe(() => {
         this.state.isForceRefresh = true;
         this.state.updates.next({ globalSearch: this.state.globalSearch, filter: this.state.filter, sort: this.state.sort, where: this.state.where });
         this.ref.markForCheck();

diff --git a/projects/novo-elements/src/elements/data-table/pagination/data-table-pagination.component.ts b/projects/novo-elements/src/elements/data-table/pagination/data-table-pagination.component.ts
@@ -146,7 +146,7 @@ export class NovoDataTablePagination<T> implements OnInit, OnDestroy {
   @Input()
   public errorLoading: boolean = false;
   @Input()
-  public paginationRefreshSubject = new Subject();
+  public paginationRefreshSubject = new Subject<void>();
 
   @Input()
   get length(): number {

diff --git a/projects/novo-elements/src/elements/data-table/state/data-table-state.service.ts b/projects/novo-elements/src/elements/data-table/state/data-table-state.service.ts
@@ -6,13 +6,13 @@ import { NovoDataTableFilterUtils } from '../services/data-table-filter-utils';
 
 @Injectable()
 export class DataTableState<T> {
-  public selectionSource = new Subject();
+  public selectionSource = new Subject<void>();
   public paginationSource = new Subject();
   public sortFilterSource = new Subject();
-  public resetSource = new Subject();
+  public resetSource = new Subject<void>();
   public expandSource = new Subject();
   public allMatchingSelectedSource = new Subject();
-  public dataLoaded = new Subject();
+  public dataLoaded = new Subject<void>();
   public dataLoadingSource = new Subject();
 
   sort: IDataTableSort = undefined;

diff --git a/projects/novo-elements/src/elements/field/field.ts b/projects/novo-elements/src/elements/field/field.ts
@@ -103,7 +103,7 @@ export class NovoFieldElement implements AfterContentInit, OnDestroy {
   private _destroyed = new Subject<void>();
 
   @Output() valueChanges: EventEmitter<any> = new EventEmitter();
-  @Output() stateChanges: EventEmitter<any> = new EventEmitter();
+  @Output() stateChanges: EventEmitter<void> = new EventEmitter();
 
   constructor(public _elementRef: ElementRef, private _changeDetectorRef: ChangeDetectorRef) {}
   /**

diff --git a/projects/novo-elements/src/package.json b/projects/novo-elements/src/package.json
@@ -16,7 +16,7 @@
     "date-fns": ">=2",
     "novo-design-tokens": "^0.0.9",
     "post-robot": "^8.0.0",
-    "rxjs": ">=6",
+    "rxjs": ">=7",
     "text-mask-addons": "^3.7.0",
     "timezone-support": "^2.0.2"
   },

diff --git a/...ts/novo-examples/src/components/data-table/data-table-remote/data-table-remote-example.ts b/...ts/novo-examples/src/components/data-table/data-table-remote/data-table-remote-example.ts
@@ -249,7 +249,7 @@ export class DataTableRemoteExample {
     value: 'asc',
   };
   public globalSearchEnabled: boolean = false;
-  public refreshSubject: Subject<boolean> = new Subject();
+  public refreshSubject: Subject<void> = new Subject();
 
   // Remote configuration
   public remoteService: RemoteDataTableService<MockData>;

diff --git a/projects/novo-examples/src/components/data-table/data-table-rows/data-table-rows-example.ts b/projects/novo-examples/src/components/data-table/data-table-rows/data-table-rows-example.ts
@@ -281,7 +281,7 @@ export class DataTableRowsExample implements AfterViewInit {
     value: 'asc',
   };
   public globalSearchEnabled: boolean = false;
-  public refreshSubject: Subject<boolean> = new Subject();
+  public refreshSubject: Subject<void> = new Subject();
 
   // Basic configuration
   public basicRows: MockData[];

diff --git a/.../novo-examples/src/components/data-table/data-table-service/data-table-service-example.ts b/.../novo-examples/src/components/data-table/data-table-service/data-table-service-example.ts
@@ -247,7 +247,7 @@ export class DataTableServiceExample {
     value: 'asc',
   };
   public globalSearchEnabled: boolean = false;
-  public refreshSubject: Subject<boolean> = new Subject();
+  public refreshSubject: Subject<void> = new Subject();
 
   // Basic configuration
   public basicService: IDataTableService<MockData>;