refactor!: New separate entry modules for each component w/ theme support #1355

bvkimball · 2022-10-17T19:59:59Z

Description

Wip
refactor!: New separate entry modules for each component.
feature: Theme Support include darkmode
refactor(date-fns)!: updating date-fns to v2 #1347
build(rxjs): updating rxjs to v7 #1350
refactor(dragula): deprecating dragula directive and service #1363
refactor(angular2-textmask)!: replacing angular2-textmask usages #1365

Verify that...

Any related demos were added and npm start and npm run build still works
New demos work in Safari, Chrome and Firefox
npm run lint passes
npm test passes and code coverage is increased
npm run build still works

Bullhorn Internal Developers

Run Novo Automation

Screenshots

* refactor(config): Updated tsconfig to standard format, and remove extraneous configs * refactor(jest): switched test back to ng-cli, also alias angular2-text-mask * chore: retest build * chore: updating test results * chore: update node version * feat(Autocomplete): Autocomplete now works with ChipList (#1326) * fix(Chips): update the ux for disabled chips (#1331) -darken the opacity to improve readability -update text color of disabled chips to look non-selectable -remove the X icon to further confer that this chip is read-only Co-authored-by: Michael Dill <michael.dill@bullhorn.com> * feat(NonIdealState): Non Ideal Loading (#1334) * Expanding non-ideal-state for use case with novo-loading * Expanding non-ideal-state for use case with novo-loading * Minor structure cleanup * Changed message on example * chore(ci): updating tokens * chore(ci): Other Tokens Updated * chore(): reverting commonjs tests * fixed tests * testing test summary * tweaking test summary * fix * fix last attempt * test * fix tsconfig * refactor(NgPackager): first step in tree-shaking * refactor(style): almost all styles removed from novo-elements.scss * BREAKING_CHANGES: Major SCSS updates * fix(build): missing script for nx * fix(build): Removing resize-observer-polyfill * fix(build): weird build error in chips missing `includes` * fixed all jest tests * fix(build): bad styleUrls * chore(build): updated test script * chore(build): Remove copy-scss script as it is handled by ng-packgr now * chore: forgot to remove script * chore(fix): Moved snapshot publish back to root Co-authored-by: Michael Dill <mdill@bullhorn.com> Co-authored-by: Michael Dill <michael.dill@bullhorn.com> Co-authored-by: antonyw89 <73492464+antonyw89@users.noreply.github.com>

* feat(Field): trying out a way to add data-auto-ids to the new novo-field elements * adding/changing field auto ids * using label instead of value

github-actions · 2022-11-07T14:56:07Z

$GITHUB_STEP_SUMMARY

github-actions · 2022-11-07T14:57:39Z

Visit the preview URL for this PR (updated for commit ca550ef):

https://novo-elements--pr1355-beta-kjsp2ge0.web.app

_{(expires Thu, 12 Jan 2023 15:49:09 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: f1783e19c2444272095017dd8ba433fff0ee3f61}

* Added formatter for dateTimePicker * Small fix * exported date-time format * Added military date-time picker * Removed military time demo

…field definitions (#1358) * feat(QueryBuilder): adding isEmpty operator to query builder field definitions * fix: removing unused imports * fix(): changing non-string isEmpty operatators to isNull

* build(rxjs): updating rxjs to v7 * fixing newly added subject * moving resize-observer-polyfill to dev dep

* upgrading date-fns to v2 * updating more date-fns calls to DateUtil calls * updating some weekday typing * using legacyParse for all DateLike conversions to Date * adding some extra error handling in isWithinRange fn * removing console log * rebase with beta and updates to data-time-format for datafns v2

…#1357) * fix(xmldom): updated xmldom dependency to address security concern * removing xmldom altogether since it is unused

Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.0 to 1.4.1. - [Release notes](https://github.com/webpack/loader-utils/releases) - [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.1/CHANGELOG.md) - [Commits](webpack/loader-utils@v1.4.0...v1.4.1) --- updated-dependencies: - dependency-name: loader-utils dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore(deps): bump loader-utils from 1.4.0 to 1.4.2 Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.0 to 1.4.2. - [Release notes](https://github.com/webpack/loader-utils/releases) - [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.2/CHANGELOG.md) - [Commits](webpack/loader-utils@v1.4.0...v1.4.2) --- updated-dependencies: - dependency-name: loader-utils dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dan Voegelin <dvoegelin@bullhorn.com>

* refactor(angular2-textmask)!: replacing angular2-textmask usages * fixing unit tests and adding custom formatting option * removing console logs * workaround for bug with adding too many digits to date * better workaround for too many date digits bug

… pointer-events (#1368)

…on (#1364) * Added date time picker to query builder

… buttons (#1375)

…ct controls (#1374) fix(NovoSelect): Fix issue with hints not displaying within Novo Select controls. Co-authored-by: Kevin Cable <cablke01@gmail.com>

* fix(): addressing multiple high level security updates * adding back and updating htmlhint dep

novo-pagination element from deprecation of novo-table removal

hiqbal01 · 2023-01-12T23:01:58Z

projects/elements/common/common.module.ts

 import { NovoTitle } from './typography/title/title.component';
+import { NovoText } from './typography/text/text.component';


This import order looks non alphabetical. Do we want to keep this?

hiqbal01 · 2023-01-12T23:11:45Z

projects/elements/common/directives/on-size.directive.ts

+import { Directive, Input, OnDestroy, TemplateRef, ViewContainerRef } from '@angular/core';
+import { Subscription } from 'rxjs';
+
+@Directive({


This directive seems new. Do we need this? Also I dont see this in the index.ts?

This is needed for talent experience to be able to do responsive components. If we end up not needing to support TX, we should remove this and put this on a feature branch.

hiqbal01 · 2023-01-12T23:15:43Z

projects/elements/common/directives/space.directive.ts

-  if (Object.keys(tokens.spacing).includes(value)) {
-    return tokens.spacing[value];
-  }
+  const cssvar = getComputedStyle(document.documentElement).getPropertyValue(`--spacing-${value}`); // #999999


is this function widely supported?

hiqbal01 · 2023-01-12T23:17:03Z

projects/elements/common/directives/theme.directive.ts

@@ -9,6 +9,7 @@ export class ThemeColorDirective {

  @HostBinding('class')
  get hb_textColor() {
+    if (!this.theme) return '';


this is new. Do we need this?

hiqbal01 · 2023-01-12T23:21:29Z

projects/elements/common/option/index.ts

+import { NovoOptgroup } from './optgroup.component';
+import { NovoPseudoCheckboxModule } from '../selection/index';
+
+@NgModule({


Should this module go into a separate file?

hiqbal01 · 2023-01-13T17:51:05Z

projects/elements/components/menu/menu.service.ts

@@ -117,7 +117,8 @@ export class NovoMenuService {
        panelClass: 'novo-menu',
        scrollStrategy: this.scrollStrategy.close(),
      });
-      // this.destroySubMenus(parentMenu);
+      this.getLastAttachedOverlay().menu.isLeaf = false;


why is this being added here?

hiqbal01 · 2023-01-13T17:53:32Z

projects/elements/components/multi-picker/multi-picker.scss

@@ -0,0 +1,76 @@
+:host {
+  // @extend chips;


hiqbal01 · 2023-01-13T17:55:39Z

projects/elements/components/multi-picker/multipicker.spec.ts

+    });
+  });
+
+  // xdescribe('Method: handleRemoveItemIfAllSelected(item)', () => {


bunch on commented and disabled tests in here, I know you didn't add them but we should remove these

hiqbal01 · 2023-01-13T18:01:55Z

projects/elements/components/pagination/pagination.ts

@@ -0,0 +1,194 @@
+import { Component, EventEmitter, HostBinding, Input, OnChanges, OnInit, Output, SimpleChanges } from '@angular/core';


This module is changing a lot. Can we discuss this in more detail?

hiqbal01 · 2023-01-13T18:06:08Z

projects/elements/components/picker/extras/base-picker-results/base-picker-results.spec.ts

+  describe('Method: onScrollDown()', () => {
+    it('should be defined.', () => {
+      expect(component.onScrollDown).toBeDefined();
+      // component.onScrollDown();


bvkimball changed the title ~~refactor!: new~~ refactor!: New separate entry modules for each component w/ theme support Oct 17, 2022

bvkimball self-assigned this Oct 17, 2022

bvkimball added breaking change labels Oct 17, 2022

Brian Kimball and others added 6 commits October 26, 2022 12:46

refactor: wip pushing for collaboration

c75f795

fix(button): Change button height token

396eaa0

fix(button): secondary button uses correct color background var

cc3d66a

feat(Field): adding data-auto-ids to the new novo-field elements (#1349)

4cb454b

* feat(Field): trying out a way to add data-auto-ids to the new novo-field elements * adding/changing field auto ids * using label instead of value

rebasing with next

f13945d

fixing import from rebase

5e14a65

agkm10 and others added 16 commits November 7, 2022 14:52

feat(dateTimePicker): Added formatter for dateTimePicker (#1361)

7d08bde

* Added formatter for dateTimePicker * Small fix * exported date-time format * Added military date-time picker * Removed military time demo

feat(QueryBuilder): adding isNull/isEmpty operators to query builder …

165707a

…field definitions (#1358) * feat(QueryBuilder): adding isEmpty operator to query builder field definitions * fix: removing unused imports * fix(): changing non-string isEmpty operatators to isNull

resolving merge conflicts

baaca71

build(rxjs): updating rxjs to v7 (#1350)

a76c79e

* build(rxjs): updating rxjs to v7 * fixing newly added subject * moving resize-observer-polyfill to dev dep

fix(xmldom): removed unused xmldom dependency due to security concern (…

ace5a44

…#1357) * fix(xmldom): updated xmldom dependency to address security concern * removing xmldom altogether since it is unused

Merge branch 'next' into beta

d15b2bf

refactor(dragula): deprecating dragula directive and service (#1363)

bc3db61

updates

f7f3d81

Merge branch 'beta' of github.com:bullhorn/novo-elements into beta

a1e32bf

Merge branch 'master' into next

4139d7f

Merge branch 'next' into beta

9c8ca28

Merge branch 'next' into beta

a3e0e1d

dvoegelin and others added 4 commits November 18, 2022 12:45

fix(NovoDataTableSortButton): fixing ng14 warning caused by animating…

f789b75

… pointer-events (#1368)

feat(date-time-condition): Added default date-time condition definiti…

c8d2cbd

…on (#1364) * Added date time picker to query builder

rebasing with next

cd4581f

fixing merge conflict build error

ba43638

dvoegelin force-pushed the next branch from a8c8da6 to 79e6d0a Compare December 1, 2022 15:03

dvoegelin and others added 15 commits December 1, 2022 13:57

fix(NovoButton): disabling enter/space keypresses on disabled/loading…

5ee7db1

… buttons (#1375)

fix(NovoSelect): Fix issue with hints not displaying within Novo Sele…

987ed02

…ct controls (#1374) fix(NovoSelect): Fix issue with hints not displaying within Novo Select controls. Co-authored-by: Kevin Cable <cablke01@gmail.com>

chore(deps): addressing multiple high level security alerts (#1376)

9bf6c79

* fix(): addressing multiple high level security updates * adding back and updating htmlhint dep

fix(tokens): Updating to latest token changes

ef03972

Merge branch 'beta' of github.com:bullhorn/novo-elements into beta

7e8e5da

fix(deps): cleaned up deps

7249adc

fix(deps): peer deps issue

8f3a281

fix(polyfill): using ponyfill for safer error handling

731a870

feat(Pagination): Missing generic

e4cbc65

novo-pagination element from deprecation of novo-table removal

resolving mere conficts with next branch

c3c5f79

linting

314efa7

Updated IMask version and change module to import

b8bb9ab

Merge branch 'beta' of github.com:bullhorn/novo-elements into beta

a262bae

fixed dependencies

591bc1d

Fixed missing contructor arg for Imask Directive

ca550ef

Base automatically changed from next to master January 5, 2023 18:43

fix(imask): Imaskmodule seems to be broken in jest tests

39086ce

hiqbal01 reviewed Jan 25, 2023

View reviewed changes

dvoegelin closed this Dec 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor!: New separate entry modules for each component w/ theme support #1355

refactor!: New separate entry modules for each component w/ theme support #1355

bvkimball commented Oct 17, 2022 •

edited by dvoegelin

github-actions bot commented Nov 7, 2022

github-actions bot commented Nov 7, 2022 •

edited

hiqbal01 Jan 12, 2023

hiqbal01 Jan 12, 2023

hiqbal01 Jan 19, 2023

hiqbal01 Jan 12, 2023

hiqbal01 Jan 12, 2023

hiqbal01 Jan 12, 2023

hiqbal01 Jan 13, 2023

hiqbal01 Jan 13, 2023

hiqbal01 Jan 13, 2023

hiqbal01 Jan 13, 2023

hiqbal01 Jan 13, 2023

		import { NovoTitle } from './typography/title/title.component';
		import { NovoText } from './typography/text/text.component';

		@@ -0,0 +1,194 @@
		import { Component, EventEmitter, HostBinding, Input, OnChanges, OnInit, Output, SimpleChanges } from '@angular/core';

refactor!: New separate entry modules for each component w/ theme support #1355

refactor!: New separate entry modules for each component w/ theme support #1355

Conversation

bvkimball commented Oct 17, 2022 • edited by dvoegelin

Description

Verify that...

Bullhorn Internal Developers

Screenshots

github-actions bot commented Nov 7, 2022

github-actions bot commented Nov 7, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bvkimball commented Oct 17, 2022 •

edited by dvoegelin

github-actions bot commented Nov 7, 2022 •

edited