Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rxjs): updating rxjs to 7.8.1 #1419

Merged
merged 29 commits into from
Jun 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
607a8ae
fix(Picker): setting min-width on novo entity picker results (#1406)
dvoegelin Apr 11, 2023
d2a51a2
chore(icons): Bump icons version (#1409)
MichaelDill Apr 14, 2023
a460420
feat(picker): add maxlength parameter for characters on input (#1411)
s-russi Apr 19, 2023
a358c00
feat(ng-packagr): initial rework for tree shakable imports
dvoegelin Apr 20, 2023
12c28e8
missed a tsconfig update
dvoegelin Apr 20, 2023
5ac2291
Merge branch 'next' into ng-packagr
dvoegelin Apr 20, 2023
d49995f
exporting individual modules for pipes, services, utils
dvoegelin Apr 21, 2023
42c31c8
Merge branch 'ng-packagr' of https://github.com/bullhorn/novo-element…
dvoegelin Apr 21, 2023
f938b83
fixing a test config issue
dvoegelin Apr 21, 2023
a3bb16e
fixing some import issues in unit tests
dvoegelin Apr 24, 2023
6820662
feat(EntityColor): Add compliance manager entity color (#1415)
zacharyjorn Apr 28, 2023
b0b3aff
feat(QueryBuilder): new address picker definition for query builder (…
dvoegelin Apr 28, 2023
acbe8c6
merge conflict
dvoegelin May 3, 2023
52572e8
fixing import issue from rebase
dvoegelin May 3, 2023
781d55b
fix(Chips): Prevent overwriting value before labels are resolved (#1416)
trenthibbard May 4, 2023
f3e3649
adding ng-package files to remaining elements
dvoegelin May 4, 2023
62a83c5
fixing some build paths
dvoegelin May 4, 2023
cd88c9d
cleaning up some more imports
dvoegelin May 4, 2023
bdbd1b3
Merge branch 'next' into ng-packagr
dvoegelin May 4, 2023
408a4da
build(rxjs): updating rxjs to 7.8.1
dvoegelin May 9, 2023
5898b0b
rebase updates
dvoegelin May 25, 2023
1879e59
Merge branch 'next' into ng-packagr
dvoegelin May 25, 2023
0f9a23b
Merge branch 'ng-packagr' into rxjs-7
dvoegelin May 25, 2023
a8a67b6
updated data table refresh subscription to match new typing
dvoegelin May 26, 2023
fabd94a
Merge branch 'next' into ng-packagr
dvoegelin May 31, 2023
2158d51
Merge branch 'ng-packagr' into rxjs-7
dvoegelin May 31, 2023
64a736e
updating project package.json
dvoegelin May 31, 2023
7658faa
Merge branch 'next' into rxjs-7
dvoegelin Jun 5, 2023
8840c3d
Merge branch 'next' into rxjs-7
dvoegelin Jun 12, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
24 changes: 13 additions & 11 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
"novo-design-tokens": "^0.0.9",
"post-robot": "9.0.30",
"resize-observer-polyfill": "^1.5.1",
"rxjs": "~6.5.5",
"rxjs": "~7.8.1",
"text-mask-addons": "^3.8.0",
"timezone-support": "^2.0.2",
"tslib": "^2.0.0",
Expand Down
4 changes: 2 additions & 2 deletions projects/novo-elements/src/elements/card/Card.ts
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,9 @@ export class CardElement implements OnChanges, OnInit {
}

@Output()
onClose: EventEmitter<any> = new EventEmitter();
onClose: EventEmitter<void> = new EventEmitter();
@Output()
onRefresh: EventEmitter<any> = new EventEmitter();
onRefresh: EventEmitter<void> = new EventEmitter();

cardAutomationId: string;
labels: NovoLabelService;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -369,14 +369,14 @@ export class NovoDataTable<T> implements AfterContentInit, OnDestroy {
}

@Input()
set refreshSubject(refreshSubject: EventEmitter<any>) {
set refreshSubject(refreshSubject: EventEmitter<void>) {
// Unsubscribe
if (this.refreshSubscription) {
this.refreshSubscription.unsubscribe();
}
if (refreshSubject) {
// Re-subscribe
this.refreshSubscription = refreshSubject.subscribe((filter: any) => {
this.refreshSubscription = refreshSubject.subscribe(() => {
this.state.isForceRefresh = true;
this.state.updates.next({ globalSearch: this.state.globalSearch, filter: this.state.filter, sort: this.state.sort, where: this.state.where });
this.ref.markForCheck();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ export class NovoDataTablePagination<T> implements OnInit, OnDestroy {
@Input()
public errorLoading: boolean = false;
@Input()
public paginationRefreshSubject = new Subject();
public paginationRefreshSubject = new Subject<void>();

@Input()
get length(): number {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ import { NovoDataTableFilterUtils } from '../services/data-table-filter-utils';

@Injectable()
export class DataTableState<T> {
public selectionSource = new Subject();
public selectionSource = new Subject<void>();
public paginationSource = new Subject();
public sortFilterSource = new Subject();
public resetSource = new Subject();
public resetSource = new Subject<void>();
public expandSource = new Subject();
public allMatchingSelectedSource = new Subject();
public dataLoaded = new Subject();
public dataLoaded = new Subject<void>();
public dataLoadingSource = new Subject();

sort: IDataTableSort = undefined;
Expand Down
2 changes: 1 addition & 1 deletion projects/novo-elements/src/elements/field/field.ts
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ export class NovoFieldElement implements AfterContentInit, OnDestroy {
private _destroyed = new Subject<void>();

@Output() valueChanges: EventEmitter<any> = new EventEmitter();
@Output() stateChanges: EventEmitter<any> = new EventEmitter();
@Output() stateChanges: EventEmitter<void> = new EventEmitter();

constructor(public _elementRef: ElementRef, private _changeDetectorRef: ChangeDetectorRef) {}
/**
Expand Down
2 changes: 1 addition & 1 deletion projects/novo-elements/src/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"date-fns": ">=2",
"novo-design-tokens": "^0.0.9",
"post-robot": "^8.0.0",
"rxjs": ">=6",
"rxjs": ">=7",
"text-mask-addons": "^3.7.0",
"timezone-support": "^2.0.2"
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ export class DataTableRemoteExample {
value: 'asc',
};
public globalSearchEnabled: boolean = false;
public refreshSubject: Subject<boolean> = new Subject();
public refreshSubject: Subject<void> = new Subject();

// Remote configuration
public remoteService: RemoteDataTableService<MockData>;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ export class DataTableRowsExample implements AfterViewInit {
value: 'asc',
};
public globalSearchEnabled: boolean = false;
public refreshSubject: Subject<boolean> = new Subject();
public refreshSubject: Subject<void> = new Subject();

// Basic configuration
public basicRows: MockData[];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ export class DataTableServiceExample {
value: 'asc',
};
public globalSearchEnabled: boolean = false;
public refreshSubject: Subject<boolean> = new Subject();
public refreshSubject: Subject<void> = new Subject();

// Basic configuration
public basicService: IDataTableService<MockData>;
Expand Down