feat(): next #1426

dvoegelin · 2023-05-25T15:15:32Z

Description

fix(Checkbox): updating checkbox, checklist, radio, tiles to have consistent disabled styling #1425
fix(Checkbox): fixing checkbox display bug and adding demo #1427
feat(ng-packagr)!: tree shakable imports #1413
refactor(dragula): deprecating dragula directive and service #1420
refactor(date-fns)!: updating date-fns to v2 #1421
refactor(rxjs): updating rxjs to 7.8.1 #1419
refactor(): moving some extended third party libs out to addons folder #1430
feat(DataTable): making data tables emit scroll events through the cdk #1431
feat(Places): adding keyboard support to places component #1433

BREAKING CHANGE: imports using absolute paths to class files should be changed to import from an entry point instead.
BREAKING CHANGE: most date-fns calls that are not accepting pure Date objects will need to be updated to instead call its respective new DateUtil function instead.
BREAKING CHANGE: due to stricter subject typing, it will now throw a build error if you are passing in a parameter to a subject which does not match the type you have set. we have had to modify some of our subject types because of this.
BREAKING CHANGE: the queryItems property on the PlacesListComponent has been renamed to matches in order to piggyback on functionality from new BasePickerResults extended component.

Verify that...

Any related demos were added and npm start and npm run build still works
New demos work in Safari, Chrome and Firefox
npm run lint passes
npm test passes and code coverage is increased
npm run build still works

Bullhorn Internal Developers

Run Novo Automation

Screenshots

…sistent disabled styling

fix(Checkbox): updating checkbox, checklist, radio, tiles to have consistent disabled styling

github-actions · 2023-05-25T15:20:55Z

Visit the preview URL for this PR (updated for commit 235a784):

https://novo-elements--pr1426-next-rglepfp9.web.app

_{(expires Wed, 05 Jul 2023 16:56:33 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: f1783e19c2444272095017dd8ba433fff0ee3f61}

…ding demo

fix(Checkbox): fixing checkbox display bug and adding demo

* fix(Picker): setting min-width on novo entity picker results (#1406) * chore(icons): Bump icons version (#1409) Co-authored-by: Michael Dill <michael.dill@bullhorn.com> * feat(picker): add maxlength parameter for characters on input (#1411) * add maxlength parameter * BH-77751: add default value for maxlength * Revert "BH-77751: add default value for maxlength" This reverts commit 3f6b851. --------- Co-authored-by: russi.sinha <russi.sinha@bullhorn.com> * feat(ng-packagr): initial rework for tree shakable imports * missed a tsconfig update * exporting individual modules for pipes, services, utils * fixing a test config issue * fixing some import issues in unit tests * feat(EntityColor): Add compliance manager entity color (#1415) * fix(Picker): setting min-width on novo entity picker results (#1406) * chore(icons): Bump icons version (#1409) Co-authored-by: Michael Dill <michael.dill@bullhorn.com> * feat(picker): add maxlength parameter for characters on input (#1411) * add maxlength parameter * BH-77751: add default value for maxlength * Revert "BH-77751: add default value for maxlength" This reverts commit 3f6b851. --------- Co-authored-by: russi.sinha <russi.sinha@bullhorn.com> * add entity color * update bullhorn-icons * update bullhorn-icons * dont update bullhorn-icons --------- Co-authored-by: Dan Voegelin <dvoegelin@bullhorn.com> Co-authored-by: Michael Dill <mdill@bullhorn.com> Co-authored-by: Michael Dill <michael.dill@bullhorn.com> Co-authored-by: Russi Sinha <87716104+s-russi@users.noreply.github.com> Co-authored-by: russi.sinha <russi.sinha@bullhorn.com> * feat(QueryBuilder): new address picker definition for query builder (#1407) * feat(QueryBuilder): new address picker definition for query builder * changing placeholder label * fix(Picker): setting min-width on novo entity picker results (#1406) * chore(icons): Bump icons version (#1409) Co-authored-by: Michael Dill <michael.dill@bullhorn.com> * fixing a few bugs * feat(picker): add maxlength parameter for characters on input (#1411) * add maxlength parameter * BH-77751: add default value for maxlength * Revert "BH-77751: add default value for maxlength" This reverts commit 3f6b851. --------- Co-authored-by: russi.sinha <russi.sinha@bullhorn.com> * switching parent element ref for overlay to fix width issue * re-focusing on the address input when selecting an option * fixing bug with multiple location conditions open at once --------- Co-authored-by: Michael Dill <mdill@bullhorn.com> Co-authored-by: Michael Dill <michael.dill@bullhorn.com> Co-authored-by: Russi Sinha <87716104+s-russi@users.noreply.github.com> Co-authored-by: russi.sinha <russi.sinha@bullhorn.com> * fixing import issue from rebase * fix(Chips): Prevent overwriting value before labels are resolved (#1416) * fix(Chips): Prevent overwriting value before labels are resolved When altering the value of a Chips picker, if some values have a label while others do not, the items with no label are no longer removed from the value * simplify handling --------- Co-authored-by: Alyssa Bryant <alyssa.bryant@bullhorn.com> * adding ng-package files to remaining elements * fixing some build paths * cleaning up some more imports --------- Co-authored-by: Michael Dill <mdill@bullhorn.com> Co-authored-by: Michael Dill <michael.dill@bullhorn.com> Co-authored-by: Russi Sinha <87716104+s-russi@users.noreply.github.com> Co-authored-by: russi.sinha <russi.sinha@bullhorn.com> Co-authored-by: Zachary Jorn <zachary.jorn@bullhorn.com> Co-authored-by: Trent Hibbard <trent.hibbard@bullhorn.com> Co-authored-by: Alyssa Bryant <alyssa.bryant@bullhorn.com>

* refactor(dragula): deprecating dragula directive and service

…onfig

* fix(Picker): setting min-width on novo entity picker results (#1406) * chore(icons): Bump icons version (#1409) Co-authored-by: Michael Dill <michael.dill@bullhorn.com> * feat(picker): add maxlength parameter for characters on input (#1411) * add maxlength parameter * BH-77751: add default value for maxlength * Revert "BH-77751: add default value for maxlength" This reverts commit 3f6b851. --------- Co-authored-by: russi.sinha <russi.sinha@bullhorn.com> * feat(ng-packagr): initial rework for tree shakable imports * missed a tsconfig update * exporting individual modules for pipes, services, utils * fixing a test config issue * fixing some import issues in unit tests * feat(EntityColor): Add compliance manager entity color (#1415) * fix(Picker): setting min-width on novo entity picker results (#1406) * chore(icons): Bump icons version (#1409) Co-authored-by: Michael Dill <michael.dill@bullhorn.com> * feat(picker): add maxlength parameter for characters on input (#1411) * add maxlength parameter * BH-77751: add default value for maxlength * Revert "BH-77751: add default value for maxlength" This reverts commit 3f6b851. --------- Co-authored-by: russi.sinha <russi.sinha@bullhorn.com> * add entity color * update bullhorn-icons * update bullhorn-icons * dont update bullhorn-icons --------- Co-authored-by: Dan Voegelin <dvoegelin@bullhorn.com> Co-authored-by: Michael Dill <mdill@bullhorn.com> Co-authored-by: Michael Dill <michael.dill@bullhorn.com> Co-authored-by: Russi Sinha <87716104+s-russi@users.noreply.github.com> Co-authored-by: russi.sinha <russi.sinha@bullhorn.com> * feat(QueryBuilder): new address picker definition for query builder (#1407) * feat(QueryBuilder): new address picker definition for query builder * changing placeholder label * fix(Picker): setting min-width on novo entity picker results (#1406) * chore(icons): Bump icons version (#1409) Co-authored-by: Michael Dill <michael.dill@bullhorn.com> * fixing a few bugs * feat(picker): add maxlength parameter for characters on input (#1411) * add maxlength parameter * BH-77751: add default value for maxlength * Revert "BH-77751: add default value for maxlength" This reverts commit 3f6b851. --------- Co-authored-by: russi.sinha <russi.sinha@bullhorn.com> * switching parent element ref for overlay to fix width issue * re-focusing on the address input when selecting an option * fixing bug with multiple location conditions open at once --------- Co-authored-by: Michael Dill <mdill@bullhorn.com> Co-authored-by: Michael Dill <michael.dill@bullhorn.com> Co-authored-by: Russi Sinha <87716104+s-russi@users.noreply.github.com> Co-authored-by: russi.sinha <russi.sinha@bullhorn.com> * fixing import issue from rebase * fix(Chips): Prevent overwriting value before labels are resolved (#1416) * fix(Chips): Prevent overwriting value before labels are resolved When altering the value of a Chips picker, if some values have a label while others do not, the items with no label are no longer removed from the value * simplify handling --------- Co-authored-by: Alyssa Bryant <alyssa.bryant@bullhorn.com> * adding ng-package files to remaining elements * fixing some build paths * cleaning up some more imports * refactor(date-fns)!: updating date-fns to v2 * fixing import * fixing build error * removing some unused imports --------- Co-authored-by: Michael Dill <mdill@bullhorn.com> Co-authored-by: Michael Dill <michael.dill@bullhorn.com> Co-authored-by: Russi Sinha <87716104+s-russi@users.noreply.github.com> Co-authored-by: russi.sinha <russi.sinha@bullhorn.com> Co-authored-by: Zachary Jorn <zachary.jorn@bullhorn.com> Co-authored-by: Trent Hibbard <trent.hibbard@bullhorn.com> Co-authored-by: Alyssa Bryant <alyssa.bryant@bullhorn.com>

* fix(Picker): setting min-width on novo entity picker results (#1406) * chore(icons): Bump icons version (#1409) Co-authored-by: Michael Dill <michael.dill@bullhorn.com> * feat(picker): add maxlength parameter for characters on input (#1411) * add maxlength parameter * BH-77751: add default value for maxlength * Revert "BH-77751: add default value for maxlength" This reverts commit 3f6b851. --------- Co-authored-by: russi.sinha <russi.sinha@bullhorn.com> * feat(ng-packagr): initial rework for tree shakable imports * missed a tsconfig update * exporting individual modules for pipes, services, utils * fixing a test config issue * fixing some import issues in unit tests * feat(EntityColor): Add compliance manager entity color (#1415) * fix(Picker): setting min-width on novo entity picker results (#1406) * chore(icons): Bump icons version (#1409) Co-authored-by: Michael Dill <michael.dill@bullhorn.com> * feat(picker): add maxlength parameter for characters on input (#1411) * add maxlength parameter * BH-77751: add default value for maxlength * Revert "BH-77751: add default value for maxlength" This reverts commit 3f6b851. --------- Co-authored-by: russi.sinha <russi.sinha@bullhorn.com> * add entity color * update bullhorn-icons * update bullhorn-icons * dont update bullhorn-icons --------- Co-authored-by: Dan Voegelin <dvoegelin@bullhorn.com> Co-authored-by: Michael Dill <mdill@bullhorn.com> Co-authored-by: Michael Dill <michael.dill@bullhorn.com> Co-authored-by: Russi Sinha <87716104+s-russi@users.noreply.github.com> Co-authored-by: russi.sinha <russi.sinha@bullhorn.com> * feat(QueryBuilder): new address picker definition for query builder (#1407) * feat(QueryBuilder): new address picker definition for query builder * changing placeholder label * fix(Picker): setting min-width on novo entity picker results (#1406) * chore(icons): Bump icons version (#1409) Co-authored-by: Michael Dill <michael.dill@bullhorn.com> * fixing a few bugs * feat(picker): add maxlength parameter for characters on input (#1411) * add maxlength parameter * BH-77751: add default value for maxlength * Revert "BH-77751: add default value for maxlength" This reverts commit 3f6b851. --------- Co-authored-by: russi.sinha <russi.sinha@bullhorn.com> * switching parent element ref for overlay to fix width issue * re-focusing on the address input when selecting an option * fixing bug with multiple location conditions open at once --------- Co-authored-by: Michael Dill <mdill@bullhorn.com> Co-authored-by: Michael Dill <michael.dill@bullhorn.com> Co-authored-by: Russi Sinha <87716104+s-russi@users.noreply.github.com> Co-authored-by: russi.sinha <russi.sinha@bullhorn.com> * fixing import issue from rebase * fix(Chips): Prevent overwriting value before labels are resolved (#1416) * fix(Chips): Prevent overwriting value before labels are resolved When altering the value of a Chips picker, if some values have a label while others do not, the items with no label are no longer removed from the value * simplify handling --------- Co-authored-by: Alyssa Bryant <alyssa.bryant@bullhorn.com> * adding ng-package files to remaining elements * fixing some build paths * cleaning up some more imports * build(rxjs): updating rxjs to 7.8.1 * updated data table refresh subscription to match new typing * updating project package.json --------- Co-authored-by: Michael Dill <mdill@bullhorn.com> Co-authored-by: Michael Dill <michael.dill@bullhorn.com> Co-authored-by: Russi Sinha <87716104+s-russi@users.noreply.github.com> Co-authored-by: russi.sinha <russi.sinha@bullhorn.com> Co-authored-by: Zachary Jorn <zachary.jorn@bullhorn.com> Co-authored-by: Trent Hibbard <trent.hibbard@bullhorn.com> Co-authored-by: Alyssa Bryant <alyssa.bryant@bullhorn.com>

#1430) * refactor(): moving some extended third party libs out to addons folder * splitting out form demo page into form and dynamic form * fixing remote data table demo * adding new addons package to main novo-elements package * removing unnecessary semicolon from scss file * reorganizing ace-editor and ckeditor examples

#1431)

* feat(Places): adding keyboard support to places component * giving query builder definition chips a max width and overflow ellipsis

dvoegelin added 3 commits May 24, 2023 13:29

fix(Checkbox): updating checkbox, checklist, radio, tiles to have con…

c048fff

…sistent disabled styling

minor bux fixes plus some more demos

20ca857

Merge pull request #1425 from bullhorn/disabled-styles

b48d6d2

fix(Checkbox): updating checkbox, checklist, radio, tiles to have consistent disabled styling

dvoegelin self-assigned this May 25, 2023

dvoegelin and others added 4 commits May 25, 2023 16:13

fix(Checkbox): fixing a display bug introduced with checkboxes and ad…

a86ca6a

…ding demo

typo

2aed427

Merge pull request #1427 from bullhorn/checkbox-checked

6e54cdb

fix(Checkbox): fixing checkbox display bug and adding demo

dvoegelin changed the title ~~feat(): next~~ feat()!: next Jun 5, 2023

dvoegelin changed the title ~~feat()!: next~~ BREAKING CHANGE: next Jun 5, 2023

refactor(dragula): deprecating dragula directive and service (#1420)

aeaba05

* refactor(dragula): deprecating dragula directive and service

dvoegelin changed the title ~~BREAKING CHANGE: next~~ BREAKING CHANGE(): next Jun 5, 2023

dvoegelin changed the title ~~BREAKING CHANGE(): next~~ feat(): next Jun 5, 2023

dvoegelin changed the title ~~feat(): next~~ feat()!: next Jun 5, 2023

dvoegelin added 3 commits June 5, 2023 15:00

feat()!: breaking change

671cddf

Breaking: change

8762af8

breaking(): adding breaking change release rule to semantic-release c…

c40a71b

…onfig

dvoegelin changed the title ~~feat()!: next~~ breaking(): next Jun 5, 2023

dvoegelin changed the title ~~breaking(): next~~ feat(): next Jun 5, 2023

dvoegelin and others added 9 commits June 12, 2023 08:45

refactor(): adding refactor release rule to semantic-release config

204bd1a

removing unnecessary config property

fa7578e

feat(DataTable): making data tables emit scroll events through the cdk (

0f0effc

#1431)

adding NovoDragulaService to FormExtras providers for FileInput

582ca68

feat(Places): adding keyboard support to places component (#1433)

759a063

* feat(Places): adding keyboard support to places component * giving query builder definition chips a max width and overflow ellipsis

feat(docs): v8 release docs (#1436)

235a784

dvoegelin merged commit 66151d4 into master Jun 28, 2023
5 checks passed

dvoegelin deleted the next branch June 28, 2023 17:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(): next #1426

feat(): next #1426

dvoegelin commented May 25, 2023 •

edited

github-actions bot commented May 25, 2023 •

edited

feat(): next #1426

feat(): next #1426

Conversation

dvoegelin commented May 25, 2023 • edited

Description

Verify that...

Bullhorn Internal Developers

Screenshots

github-actions bot commented May 25, 2023 • edited

dvoegelin commented May 25, 2023 •

edited

github-actions bot commented May 25, 2023 •

edited