Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Gradle & Kotlin #662

Merged
merged 14 commits into from
Jan 23, 2024

Conversation

manuel-martos
Copy link
Contributor

@manuel-martos manuel-martos commented Jan 22, 2024

Description

The main goal of this ticket is to upgrade Gradle and Kotlin to newer versions. The following are the newly applied versions:

  • Gradle: 8.5
  • Kotlin: 1.9.21
  • KSP: 1.9.21-1.0.16
  • AGP: 8.2.1
  • Compose Compiler: 1.5.7
  • Compose Plugin: 1.5.11
  • Dependency-analysis: 1.29.0

Check list

  • I have updated CHANGELOG.md if required.
  • I have updated documentation if required.

Comment on lines -49 to -55
compose.experimental {
uikit.application {
projectName = "Appyx"
bundleIdPrefix = "com.bumble.appyx"
}
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer needed as uikit has been removed from compose.experimental, and this same configuration can now be done in Config.xconfig files.

Comment on lines -48 to -54
compose.experimental {
uikit.application {
projectName = "Appyx"
bundleIdPrefix = "com.bumble.appyx"
}
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer needed as uikit has been removed from compose.experimental, and this same configuration can now be done in Config.xconfig files.

Comment on lines -46 to -52
compose.experimental {
uikit.application {
projectName = "Appyx"
bundleIdPrefix = "com.bumble.appyx"
}
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer needed as uikit has been removed from compose.experimental, and this same configuration can now be done in Config.xconfig files.

@@ -4,6 +4,7 @@ android.nonTransitiveRClass=false
android.useAndroidX=true
kotlin.code.style=official
kotlin.mpp.androidSourceSetLayoutVersion1.nowarn=true
kotlin.mpp.applyDefaultHierarchyTemplate=false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This option has been added to avoid warnings related to the Default Kotlin Hierarchy Template not being applied in many modules. It is advisable to address the related configuration in a separate ticket.

Comment on lines +20 to +21
kotlin = "1.9.21"
ksp = "1.9.21-1.0.16"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kotlin 1.9.20 is skipped due to an issue with KSP that makes it impossible to compile the library with this version.

@zsoltk zsoltk added this to the 2.0 milestone Jan 23, 2024
@manuel-martos manuel-martos linked an issue Jan 23, 2024 that may be closed by this pull request
@manuel-martos manuel-martos merged commit dfd4362 into bumble-tech:2.x Jan 23, 2024
7 checks passed
@manuel-martos manuel-martos deleted the upgrade-gradle-kotlin branch January 23, 2024 15:57
@manuel-martos manuel-martos self-assigned this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Gradle and Kotlin
4 participants