fix: Unable to shorten URL #696
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests passed but got this coveralls issue. |
charpeni
reviewed
Jan 22, 2022
| @@ -143,7 +143,14 @@ function createServerlessApp() { | |||
| '/results', | |||
| asyncMiddleware(async (req, res) => { | |||
| let { d } = req.query | |||
| const unpacked = jsonpack.unpack(d) | |||
There was a problem hiding this comment.
I believe we would like to keep both implementations here in order to fallback to jsonpack if the data isn't compressed so that older links are still accessible, right?
There was a problem hiding this comment.
That would probably be ideal, yes. I'll have to find some time to get back to this but some possibilities might be:
- Try to detect if the data has been compressed with
lz-stringin the handler here, although I don't see provided function fromlz-stringto do this. - Create a new major version with this breaking change.
- Add a new request param in the CLI/Node app here that indicates compression with
lz-string, then check for the presence of that request param in this handler.
My preference would be for the last option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
jsonpackwithlz-stringto help address #134.Corresponding bundlewatch PR is bundlewatch/bundlewatch#436.