Renamed overrideHook -> overrideHookState (to stay in sync with React…

… PR)
bvaughn · Feb 23, 2019 · 9f24e8c · 9f24e8c
1 parent 9b96b1f
commit 9f24e8c
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/src/backend/agent.js b/src/backend/agent.js
@@ -48,7 +48,7 @@ export default class Agent extends EventEmitter {
     bridge.addListener('highlightElementInDOM', this.highlightElementInDOM);
     bridge.addListener('inspectElement', this.inspectElement);
     bridge.addListener('overrideContext', this.overrideContext);
-    bridge.addListener('overrideHook', this.overrideHook);
+    bridge.addListener('overrideHookState', this.overrideHookState);
     bridge.addListener('overrideProps', this.overrideProps);
     bridge.addListener('overrideState', this.overrideState);
     bridge.addListener('selectElement', this.selectElement);
@@ -132,7 +132,7 @@ export default class Agent extends EventEmitter {
     }
   };
 
-  overrideHook = ({
+  overrideHookState = ({
     id,
     index,
     path,

diff --git a/src/backend/renderer.js b/src/backend/renderer.js
@@ -194,7 +194,7 @@ export function attach(
     DEPRECATED_PLACEHOLDER_SYMBOL_STRING,
   } = ReactSymbols;
 
-  const { overrideHook, overrideProps } = renderer;
+  const { overrideHookState, overrideProps } = renderer;
 
   const debug = (name: string, fiber: Fiber, parentFiber: ?Fiber): void => {
     if (__DEBUG__) {
@@ -1180,7 +1180,7 @@ export function attach(
       id,
 
       // Does the current renderer support editable hooks?
-      canEditHooks: typeof overrideHook === 'function',
+      canEditHooks: typeof overrideHookState === 'function',
 
       // Does the current renderer support editable function props?
       canEditFunctionProps: typeof overrideProps === 'function',
@@ -1215,8 +1215,8 @@ export function attach(
   ) {
     const fiber = findCurrentFiberUsingSlowPath(idToFiberMap.get(id));
     if (fiber !== null) {
-      if (typeof overrideHook === 'function') {
-        overrideHook(fiber, index, path, value);
+      if (typeof overrideHookState === 'function') {
+        overrideHookState(fiber, index, path, value);
       }
     }
   }

diff --git a/src/backend/types.js b/src/backend/types.js
@@ -35,7 +35,7 @@ export type ReactRenderer = {
   bundleType: BundleType,
 
   // 16.9+
-  overrideHook?: ?(
+  overrideHookState?: ?(
     fiber: Object,
     index: number,
     path: Array<string | number>,

diff --git a/src/devtools/views/HooksTree.js b/src/devtools/views/HooksTree.js
@@ -144,7 +144,7 @@ function HookView({ canEditHooks, hook, id, path = [] }: HookViewProps) {
     if (canEditHooks && isEditable) {
       overrideValueFn = (path: Array<string | number>, value: any) => {
         const rendererID = store.getRendererIDForElement(id);
-        bridge.send('overrideHook', {
+        bridge.send('overrideHookState', {
           id,
           index,
           path,