Remove outdated comment about Parcel workaround #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Andarist
commented
Jul 1, 2023
| // Workaround for Parcel scope hoisting (which renames objects/functions). | ||
| // Casting to :any is required to avoid corrupting the generated TypeScript types. | ||
| // See github.com/parcel-bundler/parcel/issues/8724 | ||
| (PanelGroupContext as any).displayName = "PanelGroupContext"; |
There was a problem hiding this comment.
Actually, this one might still be needed because JS engine can't infer a name here. Context isn't a function.
|
Most of these (not counting the context) aren't "needed", but I think the disambiguation in React DevTools is kind of a nice trade-off for the few extra bytes they cost. |
Andarist
force-pushed
the
fix/remove-parcel-workarounds
branch
from
43313cc
to
6e68158
Compare
Andarist
changed the title
.displayNames used as a workaround for Parcel
|
Sure, the thing that caught my eye was the comment - and not the |
bvaughn
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those should no longer be needed. If you want to set those explicitly to aid React DevTools in production then I think the
as anycast is still a preferred approach but for different reasons. TS isn't able to infer from functions with properties so some HOC-like/FP patterns don't work withReact.FC-like types (see the thread here). It's best to keep those as plain functions if possible at type-level (note that components usingforwardRefare already breaking that rule because the return type offorwardRefis a function with extra properties. You can't do much about that though unless you'd be ready to use some casts with types like this)