chore: Add support for react ^17.0.0 and ^18.0.0 #1740
Conversation
|
Is it possible to publish a new version of this library? :D PS: Thanks for the hard work here! |
|
I'm not feeling up for that task right now. Since the last time I published a release, things have changed in master that I haven't tested and can't vouch for. If you're feeling up for doing this, let's chat? |
|
Sure! I should be able to look into it during the week. 🙂 |
|
Let me know how I can help. Have a nice day. 🙂 |
|
How you could help: You can make the NPM release and agree to watch and respond to any issues filed over the next few weeks that may have been caused by the release. |
|
I can do that. If it makes sense to you, it's best then to push the NPM release on Monday, as I'll have a few AFK days at the end of this week, and I'd like to be here to respond. 🧐 👮♂️ |
|
Sounds good, Rafael. What's your NPM username btw? |
|
Hey @bvaughn. I tried publishing the NPM package to no avail. I could have sworn I accepted the NPM invitation, but maybe but perhaps I didn't. Could you send it again? :) ❯ yarn publish
yarn publish v1.22.18
[1/4] Bumping version...
info Current version: 9.22.3
question New version: 9.23.0
info New version: 9.23.0
[2/4] Logging in...
[3/4] Publishing...
(…)
error Couldn't publish package: "https://registry.yarnpkg.com/react-virtualized: You do not have permission to publish \"react-virtualized\". Are you logged in as the correct user?"
❯ npm whoami
rebelliard |
|
Anyway to get this resolved @rebelliard , @bvaughn? I think this release would help out a lot of people |
yeah, waiting for the release |
|
Any update on the release @rebelliard @bvaughn with React 17 or 18 support. |
|
Hi any update on this? |
|
Hallo, can you please prioritize this? React-window does not really do it for me. react-virtualized is a great library, react-window does not really do it for me. |
|
The changes have been published in a fork as https://www.npmjs.com/package/@enykeev/react-virtualized/v/9.22.4-mirror.1. Obviously use at your own discretion. Also, be aware, this package has a ton of deprecated and vulnerable dependencies now. It needs active support if want to continue to rely on it. |
|
@bvaughn Any ETA for the publishing? It appears as if the code is 100% stable for it to be published but it was just a permission issue (#1740 (comment))? Could we retry doing that? |
Thank you so much! How can I install type declarations of this package? I tried: npm i @types/@enykeev/react-virtualized Neither works. Any Idea? |
|
I have not published any type declarations. Given that the types have not changed, you should be able to use original declarations. You may need to somehow hint it to the ts/vscode. |
|
How's this going? |
|
ping @rebelliard @bvaughn |
|
Any update on the publish for this change? or does anyone have suggestions of other libraries similar to this? |
|
I opened an issue about this topic: |
@bvaughn @rebelliard Instead of publishing the latest master branch, A new branch can be created from latest tag as base branch, make these changes in that branch and then create a new tag on that branch and publish the release, in this way only these changes would be part of the release. I'd be happy to help! |
|
is there any updates? |
|
Unfortunately, I was not given publishing rights. |
https://nextjs.org/docs/upgrading#upgrading-from-version-10-to-11 Also includes a community pushed version of react-virtualized, see bvaughn/react-virtualized#1740 (comment)
|
Version 9.22.4 has been published with peer dependencies updated to include React 17 and 18. (No other changes from 9.22.3) https://github.com/bvaughn/react-virtualized/releases/tag/v9.22.4 |
Adds React ^17 and React ^18 as allowed peer dependencies, so that apps using this library can upgrade React without having to override any dependencies.
This pull request should superseed #1656.
npm test) all passyarn run prettier).yarn run typecheck).