Declared package side effects free #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets the package.json field sideEffects to false. This allows for better tree shaking by downstream consumers, see https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free for more information. I skimmed over all included files and I did not see anything that would count following webpack's definition of tree shaking during a production build. There is one side effect, but I believe its only used in development builds, so it would be okay to tree shake: https://github.com/bvaughn/react-window/blob/master/src/createListComponent.js#L127-L136 For more details on how this field works and why it matter see the discussion here: react-dnd/react-dnd#1577
|
Seems legit. Thanks. |
|
@bvaughn thanks for merging! would it be possible to cut a release so this is available in prod? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the package.json field sideEffects to false. This allows for better tree shaking by downstream consumers, see https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free for more information.
I skimmed over all included files and I did not see anything that would count following webpack's definition of tree shaking during a production build.
There is one side effect, but I believe its only used in development builds, so it would be okay to tree shake:
For more details on how this field works and why it matter see the discussions here: