Merge pull request CoreOffice#48 from jsbean/transform-precondition

Transform precondition to where clause in switch statement
bwetherfield · Sep 30, 2019 · e95cb2b · e95cb2b
2 parents 2e40e6a + 800a26a
commit e95cb2b
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 10 deletions.
diff --git a/Sources/XMLCoder/Decoder/XMLDecoder.swift b/Sources/XMLCoder/Decoder/XMLDecoder.swift
@@ -349,8 +349,6 @@ open class XMLDecoder {
             trimValueWhitespaces: trimValueWhitespaces
         )
 
-        print("decoder.decode(\(type), from: \(data), top level: \(topLevel)")
-
         let decoder = XMLDecoderImplementation(
             referencing: topLevel,
             options: options,

diff --git a/Sources/XMLCoder/Decoder/XMLDecoderImplementation.swift b/Sources/XMLCoder/Decoder/XMLDecoderImplementation.swift
@@ -101,8 +101,7 @@ class XMLDecoderImplementation: Decoder {
                     attributes: KeyedStorage()
                 ))
             ))
-        case let containsEmpty as SingleKeyedBox:
-            precondition(containsEmpty.element is NullBox)
+        case let containsEmpty as SingleKeyedBox where containsEmpty.element is NullBox:
             return KeyedDecodingContainer(XMLKeyedDecodingContainer<Key>(
                 referencing: self, wrapping: SharedBox(KeyedBox(
                     elements: KeyedStorage([("value", StringBox(""))]), attributes: KeyedStorage()
@@ -444,10 +443,7 @@ extension XMLDecoderImplementation {
                 storage.popContainer()
             }
 
-            print("type: \(type), box: \(box)")
-
             do {
-                print("try decoding in init")
                 decoded = try type.init(from: self)
             } catch {
                 guard case DecodingError.valueNotFound = error,

diff --git a/Sources/XMLCoder/Decoder/XMLKeyedDecodingContainer.swift b/Sources/XMLCoder/Decoder/XMLKeyedDecodingContainer.swift
@@ -324,14 +324,11 @@ extension XMLKeyedDecodingContainer {
             box = anyBox
         }
 
-        print(box)
-
         let value: T?
         if !(type is AnySequence.Type), let unkeyedBox = box as? UnkeyedBox,
             let first = unkeyedBox.first {
             // Handle case where we have held onto a `SingleKeyedBox`
             if let singleKeyed = first as? SingleKeyedBox {
-                print("single keyed here?: \(singleKeyed.element)")
                 if singleKeyed.element.isNull {
                     value = try decoder.unbox(singleKeyed)
                 } else {