Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Support for Emoticons #155

Merged
merged 4 commits into from Feb 7, 2022
Merged

Support for Emoticons #155

merged 4 commits into from Feb 7, 2022

Conversation

geshtng
Copy link
Contributor

@geshtng geshtng commented Jan 22, 2022

Support for Emoticons
But still using lang tag

Usage:

StringEMJ string `faker:"lang=emj"`

Output:

StringEMJ:馃悈馃槃馃暍馃崻馃悺

@@ -14,6 +14,7 @@ func Example_withTagsLang() {
StringCHI string `faker:"lang=chi"`
StringRUS string `faker:"lang=rus"`
StringJPN string `faker:"lang=jpn"`
StringEMJ string `faker:"lang=emj"`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @geshtng thanks for the PR.

I'm curious, is there any ISO code for this language?
I tried to find one, but couldn't find one. 馃

Copy link
Contributor Author

@geshtng geshtng Jan 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually there is none for EMJ (reference: ref-1, ref-2)
I want to make new tag like emot, but it's a bit useless (I think that "I just want a random emote, not a specific emote").
That's why I'm still using lang tag.

Edit: EMJ stand for emoji

bxcodec
bxcodec previously approved these changes Jan 31, 2022
Copy link
Owner

@bxcodec bxcodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bxcodec
Copy link
Owner

bxcodec commented Jan 31, 2022

Hey @geshtng , could you help to rebase your PR. I think it's conflict

@bxcodec bxcodec dismissed their stale review January 31, 2022 06:22

fix conflict first

@bxcodec bxcodec merged commit 7db514b into bxcodec:master Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants