Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rumqttd): handle subscription qos as max qos #707

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

swanandx
Copy link
Member

@swanandx swanandx commented Sep 4, 2023

when we subscribe to a filter ( in v3.11 / v5 ), we specify the qos, which is maximum qos , but we treat is as the qos for all publishes. to clarify, standards mention:

If a subscribing Client has been granted maximum QoS 1 for a particular Topic Filter, then a QoS 0 Application Message matching the filter is delivered to the Client at QoS 0.

i.e. if we have A subscribing to a topic with qos2, and them B publish 3 messages ( with qos 0, 1 & 2 ) to that topic. A should recv 3 messages, but with qos of 0, 1 and 2 respectively. Currently it recv all 3 with qos 2!

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Formatted with cargo fmt
  • Make an entry to CHANGELOG.md if it's relevant to the users of the library. If it's not relevant mention why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant