fix(rumqttd): handle subscription qos as max qos #707
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when we subscribe to a filter ( in v3.11 / v5 ), we specify the qos, which is maximum qos , but we treat is as the qos for all publishes. to clarify, standards mention:
i.e. if we have A subscribing to a topic with qos2, and them B publish 3 messages ( with qos 0, 1 & 2 ) to that topic. A should recv 3 messages, but with qos of 0, 1 and 2 respectively. Currently it recv all 3 with qos 2!
Type of change
Checklist:
cargo fmt
CHANGELOG.md
if it's relevant to the users of the library. If it's not relevant mention why.