feat: drop messages for which datalog doesn't exists #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h3nill
reviewed
Sep 29, 2023
Comment on lines
-1234
to
+1238
| // Create a dynamic filter if dynamic_filters are enabled for this connection | ||
| let filter_idxs = match filter_idxs { | ||
| Some(v) => v, | ||
| None if connection.dynamic_filters => { | ||
| if filter_idxs.is_empty() { | ||
| // Create a dynamic filter if dynamic_filters are enabled for this connection | ||
| if connection.dynamic_filters { | ||
| let (idx, _cursor) = datalog.next_native_offset(topic); | ||
| vec![idx] | ||
| filter_idxs = vec![idx]; | ||
| } else { | ||
| warn!(topic, "no datalog found for topic, dropping message"); |
There was a problem hiding this comment.
hmm with this we would be returning (0, 0) would that be valid?
There was a problem hiding this comment.
it was the existing behaviour, so didn't change it. If we return error, we have to add a check again so we don't disconnect the client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Checklist:
cargo fmtCHANGELOG.mdif it's relevant to the users of the library. If it's not relevant mention why.