Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ioctl_getflags and ioctl_setflags #973

Merged
merged 6 commits into from Dec 22, 2023

Conversation

fsavy-tehtris
Copy link
Contributor

This is an updated version of #525 because the original author will not revisit it.

I'm the author of the associated PR adding the missing constants in libc (rust-lang/libc#3396) and I was waiting on the libc 0.2.151 release.

@fsavy-tehtris fsavy-tehtris force-pushed the ioctl-flags branch 2 times, most recently from f2504be to 8a8f601 Compare December 15, 2023 16:17
@sunfishcode
Copy link
Member

The CI failure here looks unrelated.

Copy link
Member

@sunfishcode sunfishcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on!

src/backend/libc/io/syscalls.rs Outdated Show resolved Hide resolved
src/io/ioctl.rs Outdated Show resolved Hide resolved
src/io/ioctl.rs Outdated Show resolved Hide resolved
Copy link
Contributor Author

@fsavy-tehtris fsavy-tehtris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback! I've addressed your remarks.

src/backend/libc/io/syscalls.rs Outdated Show resolved Hide resolved
src/io/ioctl.rs Outdated Show resolved Hide resolved
@fsavy-tehtris
Copy link
Contributor Author

We might want to remove the IFlags bitflags duplication too, but I'm not sure where to put them.

@sunfishcode
Copy link
Member

Could we put IFlags in src/fs/ioctl.rs now? It doesn't appear to use different types between the two backends now.

@fsavy-tehtris
Copy link
Contributor Author

I'm moving to another company so I won't be able to revisit this PR as I'll lose access to this account.

@sunfishcode sunfishcode merged commit c4ac6b6 into bytecodealliance:main Dec 22, 2023
44 checks passed
@sunfishcode
Copy link
Member

Thanks for the PR!

@sunfishcode
Copy link
Member

This is released in rustix 0.38.29.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants