Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuttX: Remove CONFIG_INTERPRETERS_WAMR_DISABLE_HW_BOUND_CHECK #3419

Closed
wants to merge 1 commit into from

Conversation

yamt
Copy link
Collaborator

@yamt yamt commented May 13, 2024

NuttX doen't have necessary functionalities for OS_ENABLE_HW_BOUND_CHECK. This config knob merely confuses users.

NuttX doen't have necessary functionalities for OS_ENABLE_HW_BOUND_CHECK.
This config knob merely confuses users.
@no1wudi
Copy link
Collaborator

no1wudi commented May 13, 2024

If this is confusing here, please add a comment to explain it instead of deleting it directly since:

  1. It’s just a 1:1 mapping of the WAMR's config
  2. We are trying to make hardware based bound check works on NuttX

@yamt
Copy link
Collaborator Author

yamt commented May 13, 2024

We are trying to make hardware based bound check works on NuttX

you are?
how?

@no1wudi
Copy link
Collaborator

no1wudi commented May 13, 2024

Of course this feature need hardware support (MPU or MMU), there are more and more platform support the protected build or kernel build in NuttX, it's possible to implement hardware bounds check on them.

@yamt
Copy link
Collaborator Author

yamt commented May 14, 2024

Of course this feature need hardware support (MPU or MMU), there are more and more platform support the protected build or kernel build in NuttX, it's possible to implement hardware bounds check on them.

ok. good luck.

note that nuttx signal implementation is not compatible with how wamr uses it. you likely need to rewrite it too.
apache/nuttx#10326

i will close this PR. it's ok for me to keep the option as far as someone aims to implement it.

yamt added a commit to yamt/incubator-nuttx-apps that referenced this pull request May 14, 2024
@yamt yamt closed this May 14, 2024
yamt added a commit to yamt/incubator-nuttx-apps that referenced this pull request May 14, 2024
xiaoxiang781216 pushed a commit to apache/nuttx-apps that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants