Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final SIMD opcodes #222

Merged
merged 3 commits into from
Feb 19, 2021
Merged

Final SIMD opcodes #222

merged 3 commits into from
Feb 19, 2021

Conversation

yurydelendik
Copy link
Contributor

@yurydelendik yurydelendik commented Feb 9, 2021 •
edited

Tracking WebAssembly/simd#452:

  • add and update i64x2 comparison ops
  • i8x16.popcnt
  • pairwise adds
  • change op codes

TODO:

@yurydelendik
Final SIMD opcodes
97542e6 
- add and update i64x2 comparison ops
- i8x16.popcnt
- pairwise adds
- change op codes
alexcrichton
alexcrichton approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! This may need to blanket-ignore all wabt tests for the time being as well while we wait for it to update too.

@alexcrichton
Copy link
Member

Ok looks like WebAssembly/simd#452 landed! Want to do a final sync with how the opcodes ended up and I can merge?

@yurydelendik yurydelendik marked this pull request as ready for review February 19, 2021 19:17
@yurydelendik yurydelendik merged commit b5c3d98 into bytecodealliance:main Feb 19, 2021
@yurydelendik yurydelendik deleted the new-ops branch February 19, 2021 19:53
@yurydelendik yurydelendik mentioned this pull request Feb 19, 2021
Merged
@yurydelendik
Copy link
Contributor Author

crosslink to WebAssembly/simd#480

@syrusakbary syrusakbary mentioned this pull request Mar 2, 2021
Closed
@calebzulawski calebzulawski mentioned this pull request Apr 11, 2021
Closed
@workingjubilee workingjubilee mentioned this pull request Apr 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yurydelendik @alexcrichton