Replace clap attributes with command and arg #7658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iawia002
requested review from
elliottt and
pchickey
and removed request for
a team
iawia002
commented
Dec 8, 2023
| @@ -55,9 +55,8 @@ fn parse_preloads(s: &str) -> Result<(String, PathBuf)> { | |||
|
|
|||
| /// Runs a WebAssembly module | |||
| #[derive(Parser, PartialEq)] | |||
| #[structopt(name = "run")] | |||
There was a problem hiding this comment.
This actually won't work, if we want to change the name, we need to config it in https://github.com/bytecodealliance/wasmtime/blob/3b61c511a0b152d2bb40343b87b5fb1e70a87564/src/bin/wasmtime.rs#L49C1-L51
iawia002
force-pushed
the
clap-cleanup
branch
from
358d438
to
e9a6640
Compare
github-actions
bot
added
cranelift
Subscribe to Label Actioncc @cfallin, @fitzgen, @saulecabrera
This issue or pull request has been labeled: "cranelift", "isle", "winch"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reading the code, I noticed that we were mixing clap's
clap,command,arg, andstructoptattributes, and it seemed quite messy, and even though#[clap()]still works,#[arg()]and#[command()]are now recommended since clap v4, ref clap-rs/clap#4180.So this patch standardizes them, eliminating the use of outdated
clapattributes and removing some meaningless name configurations.