Add more scaling configuration

[jvisker]

No description provided.

[github-actions]

Terraform Plan:

will create 26 resources:

• aws_efs_file_system - my_efs
• aws_alb - alb
• aws_alb_listener - http_to_https
• aws_alb_listener - https
• aws_alb_listener - test_listener
• aws_alb_target_group - blue
• aws_alb_target_group - green
• aws_cloudwatch_log_group - container_log_group
• aws_cloudwatch_log_group - xray_log_group
• aws_codedeploy_app - app
• aws_codedeploy_deployment_group - deploymentgroup
• aws_ecs_cluster - new_cluster
• aws_ecs_service - service
• aws_ecs_task_definition - task_def
• aws_iam_policy - secrets_access
• aws_iam_role - task_execution_role
• aws_iam_role - task_role
• aws_iam_role_policy_attachment - secret_task_policy_attach
• aws_iam_role_policy_attachment - secrets_policy_attach
• aws_iam_role_policy_attachment - task_execution_policy_attach
• aws_iam_role_policy_attachment - xray_task_policy_attach
• aws_route53_record - a_record
• aws_route53_record - aaaa_record
• aws_security_group - alb-sg
• aws_security_group - fargate_service_sg
• local_file - appspec_json

see details

[github-actions]

Terraform Plan:

will create 26 resources:

• aws_efs_file_system - my_efs
• aws_alb - alb
• aws_alb_listener - http_to_https
• aws_alb_listener - https
• aws_alb_listener - test_listener
• aws_alb_target_group - blue
• aws_alb_target_group - green
• aws_cloudwatch_log_group - container_log_group
• aws_cloudwatch_log_group - xray_log_group
• aws_codedeploy_app - app
• aws_codedeploy_deployment_group - deploymentgroup
• aws_ecs_cluster - new_cluster
• aws_ecs_service - service
• aws_ecs_task_definition - task_def
• aws_iam_policy - secrets_access
• aws_iam_role - task_execution_role
• aws_iam_role - task_role
• aws_iam_role_policy_attachment - secret_task_policy_attach
• aws_iam_role_policy_attachment - secrets_policy_attach
• aws_iam_role_policy_attachment - task_execution_policy_attach
• aws_iam_role_policy_attachment - xray_task_policy_attach
• aws_route53_record - a_record
• aws_route53_record - aaaa_record
• aws_security_group - alb-sg
• aws_security_group - fargate_service_sg
• local_file - appspec_json

see details

[GaryGSC]

The implementation looks good because you've managed to do it in a semver-minor way, but now the description for autoscaling_config is confusing, since autoscaling_config is required to be non-null to make use of these new options that let us configure autoscaling policies and alarm.

It currently reads:

Configuration for default autoscaling policies and alarms. Set to null if you want to set up your own autoscaling policies and alarms.

[GaryGSC]

I'm fine to move forward with this if we create an issue to refactor in a future major-version release.

[jvisker]

The implementation looks good because you've managed to do it in a semver-minor way, but now the description for autoscaling_config is confusing, since autoscaling_config is required to be non-null to make use of these new options that let us configure autoscaling policies and alarm.

It currently reads:

Configuration for default autoscaling policies and alarms. Set to null if you want to set up your own autoscaling policies and alarms.

@GaryGSC I'm fine still putting an issue on the repository for a future refactor, but I did add a clarifying sentence, which dismissed your approval.

[GaryGSC]

That's a bit better now. I'd still love to eventually refactor to make use of optional object attributes, once they finally make it out of experimental status.

[GaryGSC]

Especially once they support defaults. 🙂

[jvisker]

@GaryGSC Yeah. I've been watching that feature. Unfortunately even when it does come out of experimental status it won't work with older versions of terraform.