Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile fix taken from https://github.com/nodejs/node/pull/36207 #385

Conversation

lxdicted
Copy link
Contributor

Compile fix taken from nodejs/node#36207

T_OPT is not defined on all platforms, see ares_create_query.c:35

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.593% when pulling e250667 on lxdicted:compilefix/cross-compiler-ubuntu1804-armv7-gcc-6 into c35f8ff on c-ares:master.

@bradh352
Copy link
Member

Can you share the actual build failure when using c-ares 1.17.1 ?

T_OPT is defined if not found on the system in nameser.h which is included in ares_process.c .... so I'm a little surprised this issue is being reported as this appears to be a fix introduced between 1.16.1 and 1.17.0 with commit 535763a

@lxdicted
Copy link
Contributor Author

Thanks for pointing that out, the update of namerser.h was missing.

@lxdicted lxdicted closed this Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants