More expect tests and decoupling expect test source and runner #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
very quick glance looked good :) |
|
CI is broken because of ocaml/setup-ocaml#479 I believe. I 'm still trying to figure it out on containers… |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the third and last episode of extracting the non-shrink-log parts from #172, #174, and #176 thus getting the last tests from those in play before they bit rot further...
In addition to adding more expect tests, this PR also decouples the test source code from the actual runner.
This step paves the way for using a different runner - in particular #177 - which will be reduced to one commit with a new file.
Again: The PR is probably best read one commit after another. None of this should be controversial, so objections or a quick glance and thumbs-up would be appreciated.