Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1506 Grid not aligned with ticks #1855

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #1506 Grid not aligned with ticks #1855

wants to merge 1 commit into from

Conversation

mistic100
Copy link

Add new grid.x.ticks options :

  • integer value (default: 10) -> approximate number of lines to display
  • 'auto' -> display lines aligned with axis ticks
  • array -> manually define the lines

@codecov-io
Copy link

Current coverage is 63.97% (diff: 100%)

Merging #1855 into master will decrease coverage by 0.07%

@@             master      #1855   diff @@
==========================================
  Files             1          1          
  Lines          4400       4405     +5   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           2818       2818          
- Misses         1582       1587     +5   
  Partials          0          0          

Powered by Codecov. Last update 223404a...0540f88

@panthony
Copy link
Contributor

@mistic100 Would you be kind enough to provide a test with your fix?

That would be super awesome.

I know... It's 2018.

@mistic100
Copy link
Author

I'm afraid I won't have time. I don't use this lib anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants