dependency updates #48
Conversation
yshrsmz
force-pushed
the
dependency-updates
branch
3 times, most recently
from
7e65eae
to
27b1480
Compare
yshrsmz
force-pushed
the
dependency-updates
branch
from
27b1480
to
543ccff
Compare
explicitly depending on accessibility-test-framework android/android-test#861
yshrsmz
force-pushed
the
dependency-updates
branch
from
543ccff
to
9b257b1
Compare
| @@ -77,20 +79,26 @@ dependencies { | |||
| testImplementation "junit:junit:$versions.JUNIT" | |||
| testImplementation "org.robolectric:robolectric:$versions.ROBOLECTRIC" | |||
| testImplementation "org.mockito:mockito-core:$versions.MOCKITO_ANDROID" | |||
| testImplementation "com.nhaarman:mockito-kotlin:$versions.MOCKITO_KOTLIN" | |||
| testImplementation "org.mockito.kotlin:mockito-kotlin:$versions.MOCKITO_KOTLIN" | |||
There was a problem hiding this comment.
mockito-kotlin was moved to https://github.com/mockito/mockito-kotlin
I think we should moved to mockk, Kotlin-native mocking library later
| androidTestImplementation "androidx.test.espresso:espresso-core:$versions.ANDROIDX_TEST_ESPRESSO" | ||
| androidTestImplementation "androidx.test.espresso:espresso-contrib:$versions.ANDROIDX_TEST_ESPRESSO" | ||
| androidTestImplementation("androidx.test.espresso:espresso-contrib:$versions.ANDROIDX_TEST_ESPRESSO") { | ||
| exclude group: 'com.google.protobuf', module: 'protobuf-lite' |
There was a problem hiding this comment.
protobuf-lite is a previous name of protobuf-javalite, and is conflicted with protobuf-javalite.
| @@ -66,6 +66,8 @@ dependencies { | |||
| compileOnly "javax.annotation:javax.annotation-api:$versions.JAVAX_ANNOTATION" | |||
| // This provides the protobuf.Duration for event.proto | |||
| compileOnly "com.google.api.grpc:proto-google-common-protos:$versions.COMMON_PROTOS" | |||
| implementation "com.squareup.okhttp:okhttp:2.7.5" | |||
There was a problem hiding this comment.
https://github.com/grpc/grpc-java/releases/tag/v1.46.0
okhttp: the okhttp dependency is now compile only (#8971). Okhttp’s internal HTTP/2 implementation was forked inside grpc-okhttp a long time ago, but there had been a few stray internal classes that had not been forked but should have been. That has now been fixed in preparation for OkHttp 3/4 support. Compile-only may cause a runtime failure for code using reflection on OkHttpChannelBuilder; add a dependency on okhttp 2.7.4 to resolve
| @@ -66,6 +66,8 @@ dependencies { | |||
| compileOnly "javax.annotation:javax.annotation-api:$versions.JAVAX_ANNOTATION" | |||
| // This provides the protobuf.Duration for event.proto | |||
| compileOnly "com.google.api.grpc:proto-google-common-protos:$versions.COMMON_PROTOS" | |||
| implementation "com.squareup.okhttp:okhttp:2.7.5" | |||
| implementation "com.google.protobuf:protobuf-javalite:$versions.PROTO_JAVALITE" | |||
There was a problem hiding this comment.
IDE shows error without this dependency, as com.google.protobuf.AbstractMessageLite and other lite version of protobuf base classes are not in the classpath.
| this.size shouldBeEqualTo 1 | ||
| val event = this.first().event.unpackToEvaluationEvent() | ||
| event::class shouldBeEqualTo EventOuterClass.EvaluationEvent::class | ||
| val mockObserver = spy(object : Observer { |
There was a problem hiding this comment.
| @@ -1,10 +1,9 @@ | |||
| # android sdk version | |||
| android.compileSdkVersion=30 | |||
| android.compileSdkVersion=31 | |||
There was a problem hiding this comment.
latest androidx library wants compileSdk >=31
| implementation 'androidx.appcompat:appcompat:1.0.0' | ||
| implementation 'androidx.constraintlayout:constraintlayout:1.1.3' | ||
| implementation 'com.google.android.material:material:1.0.0' | ||
| implementation 'androidx.lifecycle:lifecycle-extensions:2.0.0' |
There was a problem hiding this comment.
https://developer.android.com/jetpack/androidx/releases/lifecycle
The APIs in lifecycle-extensions have been deprecated. Instead, add dependencies for the specific Lifecycle artifacts you need.
instead we now depends on lifecycle-runtime
| @@ -7,7 +7,8 @@ def properties = new Properties() | |||
| properties.load(rootProject.file('local.properties').newDataInputStream()) | |||
|
|
|||
| android { | |||
| defaultPublishConfig "release" | |||
There was a problem hiding this comment.
Library publishes release variant by default, so it's not necessary
| @@ -7,7 +7,8 @@ def properties = new Properties() | |||
| properties.load(rootProject.file('local.properties').newDataInputStream()) | |||
|
|
|||
| android { | |||
| defaultPublishConfig "release" | |||
| namespace = "jp.bucketeer.sdk" | |||
There was a problem hiding this comment.
https://developer.android.com/studio/publish-library/prep-lib-release
since AGP 7.0 we can set a package name by this property.
| DOKKA: '0.10.1', | ||
| NEXUS_STAGING: '0.22.0', | ||
| DOKKA: '1.7.10', | ||
| NEXUS_STAGING: '0.30.0', |
There was a problem hiding this comment.
https://github.com/Codearte/gradle-nexus-staging-plugin
IMPORTANT. To make releasing to Maven Central even easier, I and Marc Phillip (the author of nexus-publish-plugin) combined forces to create a next generation, unified, 2-in-1 plugin - gradle-nexus-publish-plugin. It is a recommended solution, as our development effort will be put in that new plugin. See my blog post and the official migration guide.
I will migrate to gradle-nexus-publish-plugin in the following PR.
|
thanks! |
No description provided.