resolves issue #6

[rycbar0]

it took me more then 2 mins and also more then 5 lines of code.

[ZacSharp]

As of now MovementParkour, MovementAscend, MovementDescend and MovementFall would walk on magma (because it's canWalkOn now) without pressing shift. Additionally MovementParkour might break when jumping from magma because the damage can prevent the jump. It shouldn't attempt to jump from magma, onto magma is fine as long as no damage is taken.

[rycbar0]

should i check if the player wears boots with frost walker enchantment? those also prevent damage from magma blocks without sneaking. if so should i allow pathfinding over magma allways or only when allowSneakOverMagma is true?

[ZacSharp]

should i check if the player wears boots with frost walker enchantment? those also prevent damage from magma blocks without sneaking. if so should i allow pathfinding over magma allways or only when allowSneakOverMagma is true?

I'd say just treat magma as a harmless solid block without asking (or add yet another setting for it).

[rycbar0]

i understand this that i should remove the allowSneakOverMagma setting and allways allow pathfinding over magma

[rycbar0]

TODO-list:

• javadoc for isOverMagma()
• javadoc for hasFrostwalker()
• adjust jump timing when sneak ascending
• sneak when breaking a block while standing on magma
• evaluate optimization potential of costcalculation in MovementDiagonal

[ZacSharp]

i understand this that i should remove the allowSneakOverMagma setting and allways allow pathfinding over magma

Oh, sorry, that's my comment editing gone wrong. I originally intended to write something along the lines of "I'd say just use the boots without asking (or make it yet another setting)", but obviously I reworded that beyond repair.
As long as it is reliable I don't see a need for a setting (it complicates things after all) and frostwalker boots are 100% reliable.

As for "allowSneakOverMagma": I personally don't care.

[ZacSharp]

To sneak while breaking blocks, Movement.prepared might be the right place.

[ZacSharp]

Autoformatting caused quite a bunch of unrelated changes but ok.
Code looks good to me now (apart from the todo comment).

It mostly sneaks way to much and not at all after parkour jumps onto magma.

2022-10-30.11-02-13.mp4

Do you think you could make it more like this (but without sneaking too little)?

2022-10-30.11-21-36.mp4