daemon: implement an event loop for the main thread #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sandydoo
commented
May 14, 2024
sandydoo
commented
- Refactor the main blocking thread into an event loop to make it possible to manage internal daemon state. For example, react to new messages, add and remove active sockets, etc.
- Add ping-pong messages to the protocol to allow for liveness checks.
- Track and handle active client sockets.
- Remove code that disabled non-blocking mode for client connections. This causes hangs in certain situations. Everything now works perfectly fine without this.
Not a safe operation, apparently.
- Add an event loop to the daemon. - Track client sockets that connect to the daemon. - Add ping/pong messages to the protocol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.