Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let PostgreSQL support relative $DEVENV_ROOT #706

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Let PostgreSQL support relative $DEVENV_ROOT #706

wants to merge 3 commits into from

Conversation

Atry
Copy link
Contributor

@Atry Atry commented Jul 7, 2023 •
edited

unix_socket_directories is by default relative to $PGDATA, therefore unix_socket_directories=. should behave the same as unix_socket_directories=$PGDATA when $PGDATA is absolute. However, unix_socket_directories=. also works with relative a $PGDATA because it does not depend on $PGDATA any more.

@Atry
Let Postgres support relative $DEVENV_ROOT
ea1eeaa 
`unix_socket_directories` is by default relative to $PGDATA, therefore `unix_socket_directories=.` should work the same as `unix_socket_directories=$PGDATA` when `$PGDATA` is absolute. However, `unix_socket_directories=.` also works with relative $PGDATA
@Atry Atry mentioned this pull request Jul 7, 2023
Closed
@Atry Atry changed the title Let Postgres support relative $DEVENV_ROOT Let PostgreSQL support relative $DEVENV_ROOT Jul 7, 2023
@domenkozar
Copy link
Member

Why is realpath needed? We need to keep PGHOST at the Nix level since it's used often.

@domenkozar
Copy link
Member

5e150be

@Atry
Copy link
Contributor Author

Atry commented Jul 11, 2023

We need realpath because PGHOST does not support relative path

@Atry
Copy link
Contributor Author

Atry commented Jul 11, 2023

We need to keep PGHOST at the Nix level since it's used often.

I didn't find PGHOST being used anywhere in Nix files https://github.com/search?q=repo%3Acachix%2Fdevenv%20PGHOST&type=code

@Atry
Copy link
Contributor Author

Atry commented Oct 4, 2023

@domenkozar What do think about this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Atry @domenkozar